Bug #75421

Faulty change detection in FAL indexer

Added by Markus Friedrich over 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2016-04-06
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The FAL indexer currently regards all files as changed, since value and type are checked in detectChangedFilesInStorage():

                ...
                if ($indexRecord['modification_date'] !== $modificationTime['mtime'] || $indexRecord['missing']) {
                    $this->filesToUpdate[$fileIdentifier] = $indexRecord;
                }
                ...

The modification date returned by SplFileInfo is an integer but the modification_date in the index record is a string, so all files get updated

array(2 items)
   $indexRecord['modification_date'] => "1455633777" (10 chars)
   $modificationTime['mtime'] => 1455633777 (integer)

Related issues

Related to TYPO3 Core - Bug #67573: Insufficient detection of changed files in FAL indexer Closed 2015-06-17

Associated revisions

Revision da3ac98a (diff)
Added by Wouter Wolters over 3 years ago

[BUGFIX] Modification date comparison fixed in FAL indexer

modification_date is a string from the database and SplFileInfo
mtime is returned as integer. Cast modification_date to
an integer too.

Resolves: #75421
Releases: master,7.6
Change-Id: I7523f9f722af8cc5f4e137e32bf07e2c3105214d
Reviewed-on: https://review.typo3.org/47519
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>

Revision 23b6a230 (diff)
Added by Wouter Wolters over 3 years ago

[BUGFIX] Modification date comparison fixed in FAL indexer

modification_date is a string from the database and SplFileInfo
mtime is returned as integer. Cast modification_date to
an integer too.

Resolves: #75421
Releases: master,7.6
Change-Id: I7523f9f722af8cc5f4e137e32bf07e2c3105214d
Reviewed-on: https://review.typo3.org/47533
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>

History

#1 Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47519

#2 Updated by Wouter Wolters over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#3 Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47533

#4 Updated by Wouter Wolters over 3 years ago

  • Status changed from Under Review to Resolved

#5 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF