Project

General

Profile

Actions

Bug #75421

closed

Faulty change detection in FAL indexer

Added by Markus Friedrich about 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2016-04-06
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The FAL indexer currently regards all files as changed, since value and type are checked in detectChangedFilesInStorage():

                ...
                if ($indexRecord['modification_date'] !== $modificationTime['mtime'] || $indexRecord['missing']) {
                    $this->filesToUpdate[$fileIdentifier] = $indexRecord;
                }
                ...

The modification date returned by SplFileInfo is an integer but the modification_date in the index record is a string, so all files get updated

array(2 items)
   $indexRecord['modification_date'] => "1455633777" (10 chars)
   $modificationTime['mtime'] => 1455633777 (integer)

Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #67573: Insufficient detection of changed files in FAL indexerClosedDaniel Maier2015-06-17

Actions
Actions #1

Updated by Gerrit Code Review about 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47519

Actions #2

Updated by Wouter Wolters about 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #3

Updated by Gerrit Code Review about 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47533

Actions #4

Updated by Wouter Wolters about 8 years ago

  • Status changed from Under Review to Resolved
Actions #5

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF