Actions
Bug #75421
closedFaulty change detection in FAL indexer
Status:
Closed
Priority:
Must have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2016-04-06
Due date:
% Done:
100%
Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
Description
The FAL indexer currently regards all files as changed, since value and type are checked in detectChangedFilesInStorage():
... if ($indexRecord['modification_date'] !== $modificationTime['mtime'] || $indexRecord['missing']) { $this->filesToUpdate[$fileIdentifier] = $indexRecord; } ...
The modification date returned by SplFileInfo is an integer but the modification_date in the index record is a string, so all files get updated
array(2 items) $indexRecord['modification_date'] => "1455633777" (10 chars) $modificationTime['mtime'] => 1455633777 (integer)
Updated by Gerrit Code Review over 8 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47519
Updated by Wouter Wolters over 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset da3ac98a92a7605be72c30cccb48931f012ff5c2.
Updated by Gerrit Code Review over 8 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47533
Updated by Wouter Wolters over 8 years ago
- Status changed from Under Review to Resolved
Applied in changeset 23b6a230ef140f02dd3ad39e5407e51cdf675e54.
Actions