Bug #75881

Improper usage of processed files

Added by Philipp Gampe over 3 years ago. Updated 5 months ago.

Status:
Needs Feedback
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2016-04-23
Due date:
% Done:

0%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
medium
Is Regression:
No
Sprint Focus:

Description

$file->process(...) returns a ProcessedFile object, even it could not process the image.
The ProcessedFile has a method isProcessed() that needs to be used to check the result, otherwise ProcessedFile returns the properties of the original file.

History

#1 Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47871

#2 Updated by Philipp Gampe almost 3 years ago

  • Status changed from Under Review to New
  • Assignee deleted (Philipp Gampe)
  • Complexity set to medium

#3 Updated by Susanne Moog 6 months ago

  • Status changed from New to Needs Feedback

After revisiting this topic a few years later, I've come to the conclusion that I either don't get what the issue is anymore or there is no issue. Basically, the naming of "processed" is a bit ambivalent as in this case it simply means "hey, I've seen that file at some point" and not "I've done something with it". From the (current) code, I see no issue. Do you?

#4 Updated by Philipp Gampe 5 months ago

I did not verify lately, but at least the back in the days, the API returned an unprocessed file object in case of errors. If this is the expected behavior, then this should be documented.

Ambivalence in the API is an own bug category :/

You can as well go ahead and close this one. If nobody else bother since several years now, it must be good enough and time may be better spend elsewhere.

Also available in: Atom PDF