Project

General

Profile

Actions

Bug #76031

closed

getPageOverlay Hook does not loop through pages by reference

Added by Andreas Allacher over 8 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Frontend
Start date:
2016-05-03
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
On Location Sprint

Description

With the introduction of getPagesOverlay the page array is looped to pass each page to the getPageOverlay_preProcess hook:

foreach ($pagesInput as $origPage) {
                foreach ($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_page.php']['getPageOverlay'] as $classRef) {
                    $hookObject = GeneralUtility::getUserObj($classRef);
                    if (!$hookObject instanceof PageRepositoryGetPageOverlayHookInterface) {
                        throw new \UnexpectedValueException('$hookObject must implement interface ' . PageRepositoryGetPageOverlayHookInterface::class, 1269878881);
                    }
                    $hookObject->getPageOverlay_preProcess($origPage, $lUid, $this);
                }
            }

However, as the foreach loop doesn't use & before $origPage modified values in getPageOverlay_preProcess will never make it back to the original page array.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Feature #64258: PageRepository::getPageOverlay() for multiple pages at onceClosed2015-01-13

Actions
Actions #1

Updated by Gerrit Code Review over 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47996

Actions #2

Updated by Nicole Cordes over 8 years ago

Going back to one commit before the changes to getPageOverlay() were made (commit hash 030e067) shows there wasn't any possibility to change the page before.

Actions #3

Updated by Nicole Cordes over 8 years ago

  • Sprint Focus set to On Location Sprint
Actions #4

Updated by Gerrit Code Review over 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47996

Actions #5

Updated by Andreas Allacher over 8 years ago

The issue was introduced with #64258
because that adds a foreach loop between the page array and the hook object.

Actions #6

Updated by Gerrit Code Review over 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47996

Actions #7

Updated by Andreas Allacher over 8 years ago

Maybe someone from the core team could modify the is regression setting?

Actions #8

Updated by Gerrit Code Review over 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/47996

Actions #9

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48479

Actions #10

Updated by Anonymous over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #11

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF