Project

General

Profile

Actions
Copy link

Task #76045

closed

Naming of fe_users field "is_online"

Added by Thomas Löffler over 8 years ago. Updated over 8 years ago.

Status:
Closed
Priority:
Won't have this time
Assignee:
-
Category:
-
Target version:
-
Start date:
2016-05-04
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The field "is_online" implicates a boolean field, if a frontend user is online or not.
But the field is updated with a timestamp and reflects the last activity:

typo3/sysext/frontend/Classes/Controller/TypoScriptFrontendController.php:1051

// For every 60 seconds the is_online timestamp is updated.
if (is_array($this->fe_user->user) && $this->fe_user->user['uid'] && $this->fe_user->user['is_online'] < $GLOBALS['EXEC_TIME'] - 60) {
    $this->getDatabaseConnection()->exec_UPDATEquery('fe_users', 'uid=' . (int)$this->fe_user->user['uid'], array('is_online' => $GLOBALS['EXEC_TIME']));
}

What about changing field name to e.g. "last_online_activity" or "last_activity"?

Actions
Copy link
 #1

Updated by Georg Ringer over 8 years ago

  • Status changed from New to Closed
  • Priority changed from Should have to Won't have this time

Thanks for creating this issue!
Even though it is valid, this would be very breaking and doesn't improve anythign else. Every extension which uses this field would then required to be changed.

therefore I am closing this issue

Actions
Copy link

Also available in: Atom PDF