Project

General

Profile

Actions
Copy link

Bug #76302

closed

Fix output and inconsistencies in DebugUtility

Added by Helmut Hummel almost 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
Candidate for patchlevel
Start date:
2016-05-25
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The DebugUtility always was and still is a crude mixture of methods, which creates debug output for different targets.

This never worked properly, but got even worse with the refactoring of the backend debugging console #65956

Since then the output of objects and array in a different context is so ugly and unusable, that it can considered broken (the result of json_encode of an object is not really helpful for a human).

Besides that, the context check is broken since a while, so that still HTML is shown in CLI context.

Last but not least, when outputting HTML, proper encoding is missing in most of the places.

Actions
Copy link
 #1

Updated by Helmut Hummel almost 8 years ago

The following scenarios should be tested

Variable to debug $a:

$a = new \stdClass();
$b = new \stdClass();
$c = new \stdClass();
$b->c = $c;
$a->b = $b;

Code to test:

\TYPO3\CMS\Core\Utility\DebugUtility::debug($a, 'Header', 'Group')
\TYPO3\CMS\Core\Utility\DebugUtility::debugRows($a, 'Header')
\TYPO3\CMS\Core\Utility\DebugUtility::debugInPopUpWindow($a, 'Header', 'Group')
\TYPO3\CMS\Core\Utility\DebugUtility::printArray($a)

Scenarios:

  1. Frontend plugin (or similar)
  2. Backend module in frame
  3. Backend module in standalone window (not nested in backend)
  4. cli script
Actions
Copy link
 #2

Updated by Gerrit Code Review almost 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48288

Actions
Copy link
 #3

Updated by Gerrit Code Review almost 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48288

Actions
Copy link
 #4

Updated by Gerrit Code Review almost 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48288

Actions
Copy link
 #5

Updated by Gerrit Code Review almost 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48288

Actions
Copy link
 #6

Updated by Gerrit Code Review almost 8 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48288

Actions
Copy link
 #7

Updated by Gerrit Code Review almost 8 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48288

Actions
Copy link
 #8

Updated by Gerrit Code Review almost 8 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48288

Actions
Copy link
 #9

Updated by Gerrit Code Review almost 8 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48288

Actions
Copy link
 #10

Updated by Gerrit Code Review almost 8 years ago

Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48288

Actions
Copy link
 #11

Updated by Gerrit Code Review almost 8 years ago

Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48288

Actions
Copy link
 #12

Updated by Gerrit Code Review almost 8 years ago

Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48288

Actions
Copy link
 #13

Updated by Anonymous almost 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions
Copy link
 #14

Updated by Gerrit Code Review almost 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48384

Actions
Copy link
 #15

Updated by Gerrit Code Review almost 8 years ago

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48384

Actions
Copy link
 #16

Updated by Gerrit Code Review almost 8 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48398

Actions
Copy link
 #17

Updated by Gerrit Code Review almost 8 years ago

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48398

Actions
Copy link
 #18

Updated by Anonymous almost 8 years ago

  • Status changed from Under Review to Resolved
Actions
Copy link
 #19

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF