Bug #76408

Bug #71298: Fix missing/broken RTE features after Link Handler API merge

Filebrowser: Plus-Sign doesn't disappear for not-selectable Items

Added by Kevin Ditscheid almost 3 years ago. Updated 8 months ago.

Status:
Closed
Priority:
Could have
Category:
Backend API
Target version:
-
Start date:
2016-05-31
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
5.6
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:
On Location Sprint

Description

The plus-sign next to the items name in the filebrowser does not disappear if the file is not selectable. I've overwritten the method TYPO3\CMS\Recordlist\Browser\FileBrowser->fileIsSelectableInFileList to introduce the added group rights to the FAL and prevent files from being used in public, if access restricted. The wanted behaviour is correct, the file is not selectable, but the icon that is set around Line 333, in method renderFilesInFolder (actions-edit-add) is not effected by this. It will be rendered regardless if item is selectable or not.

Using TYPO3 7.6.9

filebrowser-fileisselectable-false.png View (71.3 KB) Kevin Ditscheid, 2016-05-31 19:58

Associated revisions

Revision b4c8f08d (diff)
Added by Michael Oehlhof over 2 years ago

[BUGFIX] Filebrowser: Plus-Sign disappear for not-selectable items now

Resolves: #76408
Releases: master, 7.6
Change-Id: I20cfc02b588776f4e76980aa68dfe5c032103563
Reviewed-on: https://review.typo3.org/50786
Reviewed-by: Markus Klein <>
Tested-by: TYPO3com <>
Reviewed-by: Kevin Ditscheid <>
Reviewed-by: Joerg Boesche <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Gleb Levitin <>
Tested-by: Gleb Levitin <>
Reviewed-by: Jan Helke <>
Tested-by: Jan Helke <>

Revision 6a77b6c5 (diff)
Added by Michael Oehlhof over 2 years ago

[BUGFIX] Filebrowser: Plus-Sign disappear for not-selectable items now

Resolves: #76408
Releases: master, 7.6
Change-Id: I20cfc02b588776f4e76980aa68dfe5c032103563
Reviewed-on: https://review.typo3.org/50981
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Markus Klein over 2 years ago

  • Parent task set to #71298

#2 Updated by Michael Oehlhof over 2 years ago

  • Status changed from New to In Progress
  • Assignee set to Michael Oehlhof

#3 Updated by Gerrit Code Review over 2 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50786

#4 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50786

#5 Updated by Michael Oehlhof over 2 years ago

  • Sprint Focus set to On Location Sprint

#6 Updated by Michael Oehlhof over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Gerrit Code Review over 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50981

#8 Updated by Michael Oehlhof over 2 years ago

  • Status changed from Under Review to Resolved

#9 Updated by Benni Mack 8 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF