Bug #76441: Update storage index (scheduler) and file mounts - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #76441

closed

Update storage index (scheduler) and file mounts

Added by DMK E-BUSINESS GmbH almost 8 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Category:

File Abstraction Layer (FAL)

Target version:

Start date:

2016-06-03

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

6.2

PHP Version:

5.5

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

If the CLI BE user has file mounts in a storage, the Update storage index (scheduler) task will only index files in the first file mount. This is because of the call $this->storage->getRootLevelFolder() in TYPO3\CMS\Core\Resource\Index\Indexer::processChangesInStorages()

Maybe the file mounts shouldn't be respected at that point but later when each file is checked. This way changed files would be detected in all file mounts.

I added the root folder (/) as a file mount as workaround.

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by DMK E-BUSINESS GmbH almost 8 years ago

Is it a option to remove all file mounts of the CLI user or would this lead to having no read rights?

Actions

Copy link

Updated by DMK E-BUSINESS GmbH almost 8 years ago

EDIT: I'm not completely sure but I think this was not always a problem. I believe in former versions all file mounts were indexed. (I don't know since when this is broken)

Actions

Copy link

Updated by Frans Saris almost 8 years ago

Status changed from New to Accepted

Hi good catch.

IMO this part of typo3/sysext/core/Classes/Resource/Index/Indexer.php:

    /**
     * @return void
     */
    public function processChangesInStorages()
    {
        // get all file-identifiers from the storage
        $availableFiles = $this->storage->getFileIdentifiersInFolder($this->storage->getRootLevelFolder()->getIdentifier(), true, true);
        $this->detectChangedFilesInStorage($availableFiles);
        $this->processChangedAndNewFiles();

        $this->detectMissingFiles();
    }

needs to be changed to

    /**
     * @return void
     */
    public function processChangesInStorages()
    {
        // get all file-identifiers from the storage
        $availableFiles = $this->storage->getFileIdentifiersInFolder($this->storage->getRootLevelFolder(false)->getIdentifier(), true, true);
        $this->detectChangedFilesInStorage($availableFiles);
        $this->processChangedAndNewFiles();

        $this->detectMissingFiles();
    }

See the difference in the getRootLevelFolder() call

Could you push a patch for this to gerrit?

Actions

Copy link

Updated by Gerrit Code Review almost 8 years ago

Status changed from Accepted to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48560

Actions

Copy link

Updated by Stephan Großberndt almost 8 years ago

I guess this happens on master too? This should be merged in master first then and be backported to 6.2 afterwards

Actions

Copy link

Updated by Gerrit Code Review almost 8 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48561

Actions

Copy link

Updated by Gerrit Code Review almost 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48561

Actions

Copy link

Updated by Gerrit Code Review almost 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48561

Actions

Copy link

Updated by Gerrit Code Review almost 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48561

Actions

Copy link

#10

Updated by Gerrit Code Review almost 8 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48561

Actions

Copy link

#11

Updated by Gerrit Code Review almost 8 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48887

Actions

Copy link

#12

Updated by Hannes Bochmann almost 8 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 3e5ddbbfcbc547fa412ddc147299d8996bdf0392.

Actions

Copy link

#13

Updated by Gerrit Code Review almost 8 years ago

Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48894

Actions

Copy link

#14

Updated by Gerrit Code Review almost 8 years ago

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48894

Actions

Copy link

#15