Bug #76692

Wrong check for showitem fields in ExtensionManagementUtility::addToAllTCAtypes

Added by Viktor Firus over 4 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2016-06-19
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

At adding of new field to TCA it is possible, that the field won't added, because if one of the existing field contains partial the new field name, it will be ignored.

ex: If an existing field named "something_else_hello" and i wan't add field named "hello", it woul'd be ignored.

The strpos in this check are incorrect:

// skip if fields were already added
if (!isset($typeDetails['showitem']) || strpos($typeDetails['showitem'], $newFieldsString) !== false) {
continue;
}


Related issues

Related to TYPO3 Core - Bug #73490: ExtensionManagementUtility::addToAllTCAtypes cannot add fields which appear anywhere in Labels/PaletteNames etcClosed2016-02-16

Actions
#1

Updated by Stephan Großberndt over 4 years ago

  • Subject changed from Bug in static function \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addToAllTCAtypes to Wrong check for showitem fields in ExtensionManagementUtility::addToAllTCAtypes
#2

Updated by Wouter Wolters over 4 years ago

  • Status changed from New to Closed

Hi, I close this as a duplicate ticket of #73490 will continue there.

Also available in: Atom PDF