Bug #73490: ExtensionManagementUtility::addToAllTCAtypes cannot add fields which appear anywhere in Labels/PaletteNames etc - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #73490

closed

ExtensionManagementUtility::addToAllTCAtypes cannot add fields which appear anywhere in Labels/PaletteNames etc

Added by Robert Vock about 8 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Backend API

Target version:

Start date:

2016-02-16

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

If you try to add a field to the showitem-definition using ExtensionManagementUtility::addToAllTCAtypes and this field matches with strpos, it is not added:
https://github.com/TYPO3/TYPO3.CMS/blob/3c5865b61da2125ffee75cbe05e636f74851b987/typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php#L304

Example:
ExtensionManagementUtility::addToAllTCAtypes('tt_content', 'image', 'textmedia', 'replace:assets');
'image' is contained within '--palette--;LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:palette.imagelinks;imagelinks,' and will not be added

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by Wouter Wolters almost 8 years ago

Status changed from New to Needs Feedback

Looks like this has been fixed within https://forge.typo3.org/issues/75830
Can you check if that works for you?

Actions

Copy link

Updated by Robert Vock almost 8 years ago

No, it is not fixed. The other bug was about the colon in the position argument and in the LLL:-string.

This bug is about the incorrect check, if a field already is in the showitem-definition. (See direct link to the buggy line)

Actions

Copy link

Updated by Wouter Wolters almost 8 years ago

Status changed from Needs Feedback to Accepted

Actions

Copy link

Updated by Gerrit Code Review almost 8 years ago

Status changed from Accepted to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48663

Actions

Copy link

Updated by Gerrit Code Review almost 8 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48780

Actions

Copy link

Updated by Wouter Wolters almost 8 years ago

Status changed from Under Review to Resolved
% Done changed from 0 to 100

Applied in changeset 996d323ee13a3db7e33843f644322c7477d7fb4b.

Actions

Copy link

Updated by Gerrit Code Review almost 8 years ago

Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48781

Actions

Copy link

Updated by Wouter Wolters almost 8 years ago

Status changed from Under Review to Resolved

Applied in changeset 0c1845430a268028b733ed53ed9aa9c0df132f32.

Actions

Copy link

Updated by Gerrit Code Review almost 8 years ago

Status changed from Resolved to Under Review

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48781

Actions

Copy link

#10