Project

General

Profile

Actions

Bug #73490

closed

ExtensionManagementUtility::addToAllTCAtypes cannot add fields which appear anywhere in Labels/PaletteNames etc

Added by Robert Vock almost 9 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend API
Target version:
-
Start date:
2016-02-16
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

If you try to add a field to the showitem-definition using ExtensionManagementUtility::addToAllTCAtypes and this field matches with strpos, it is not added:
https://github.com/TYPO3/TYPO3.CMS/blob/3c5865b61da2125ffee75cbe05e636f74851b987/typo3/sysext/core/Classes/Utility/ExtensionManagementUtility.php#L304

Example:
ExtensionManagementUtility::addToAllTCAtypes('tt_content', 'image', 'textmedia', 'replace:assets');
'image' is contained within '--palette--;LLL:EXT:frontend/Resources/Private/Language/locallang_ttc.xlf:palette.imagelinks;imagelinks,' and will not be added


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #76692: Wrong check for showitem fields in ExtensionManagementUtility::addToAllTCAtypesClosed2016-06-19

Actions
Actions #1

Updated by Wouter Wolters over 8 years ago

  • Status changed from New to Needs Feedback

Looks like this has been fixed within https://forge.typo3.org/issues/75830
Can you check if that works for you?

Actions #2

Updated by Robert Vock over 8 years ago

No, it is not fixed. The other bug was about the colon in the position argument and in the LLL:-string.

This bug is about the incorrect check, if a field already is in the showitem-definition. (See direct link to the buggy line)

Actions #3

Updated by Wouter Wolters over 8 years ago

  • Status changed from Needs Feedback to Accepted
Actions #4

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Accepted to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48663

Actions #5

Updated by Gerrit Code Review over 8 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48780

Actions #6

Updated by Wouter Wolters over 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #7

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48781

Actions #8

Updated by Wouter Wolters over 8 years ago

  • Status changed from Under Review to Resolved
Actions #9

Updated by Gerrit Code Review over 8 years ago

  • Status changed from Resolved to Under Review

Patch set 2 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48781

Actions #10

Updated by Wouter Wolters over 8 years ago

  • Status changed from Under Review to Resolved
Actions #11

Updated by Benni Mack about 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF