Task #76866

EXT:form - Handle checkbox and radio correctly in confirmation and postProcessor

Added by Gianluigi Martino over 4 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Should have
Category:
Form Framework
Target version:
-
Start date:
2016-06-29
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
Sprint Focus:
On Location Sprint

Description

Show value of checkbox and radio in confirmation and send via html and plain mail if inserted.


Related issues

Related to TYPO3 Core - Bug #76823: EXT:form - checkboxes are missing in html mails Closed 2016-06-28

Associated revisions

Revision 13864e00 (diff)
Added by Gianluigi Martino over 4 years ago

[BUGFIX] EXT:form - Handle values of CHECKBOX and RADIO correctly

Show values of CHECKBOX and RADIO elements on confirmation page.
Send values in HTML and plain text mails.

Change-Id: I59e6ed255d70902567812a9f7d9c6550c72f5a2d
Resolves: #76866
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/48720
Tested-by: Bamboo TYPO3com <>
Reviewed-by: Bjoern Jacob <>
Tested-by: Bjoern Jacob <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

Revision c613eeb2 (diff)
Added by Bjoern Jacob about 4 years ago

[BUGFIX] EXT:form - Handle values of CHECKBOX and RADIO correctly

Show values of CHECKBOX and RADIO elements on confirmation page.
Send values in HTML and plain text mails.

Change-Id: I59e6ed255d70902567812a9f7d9c6550c72f5a2d
Resolves: #76866
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/49290
Reviewed-by: Anja Leichsenring <>
Tested-by: Anja Leichsenring <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Gerrit Code Review over 4 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48720

#2 Updated by Gerrit Code Review over 4 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48720

#3 Updated by Gerrit Code Review over 4 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48720

#4 Updated by Bjoern Jacob over 4 years ago

  • Subject changed from EXT:form - Send value of checkbox in html mail to EXT:form - Handle checkbox and radio correctly in confirmation and postProcessor
  • Description updated (diff)

It is way more complexe than thought in the first run. We have to tackle some more places. The following data shows a comparison with v6.2.

Confirmation

  • checkbox: <label /> <inputvalue /> code
  • radio: <label /> <inputvalue /> code

This never worked in 6.2 which means the value was never shown.

Mail HTML

  • checkbox: <td style="width: 200px;"><label /></td><td><inputvalue /></td> code
  • radio: <td style="width: 200px;"><label /></td><td><inputvalue /></td> code

This worked in 6.2.

Mail Plain

This never worked in 6.2 which means the value was never shown.

Test example


enctype = multipart/form-data
method = post
prefix = tx_form
confirmation = 1
postProcessor {
    1 = mail
    1 {
        recipientEmail = forms@tritum.de
        senderEmail = forms@tritum.de
        subject = Test
    }
}
10 = CHECKBOX
10 {
    type = checkbox
    name = contact_checkbox
        value = Check value.
    label {
        value = Check label?
    }
}
20 = RADIO
20 {
    type = radio
    name = contact_radio
    value = Radio value.
    label {
        value = Radio label?
    }
}
30 = SUBMIT
30 {
    type = submit
    name = 3
    value = Send
}

#5 Updated by Gerrit Code Review over 4 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48720

#6 Updated by Gianluigi Martino over 4 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Gerrit Code Review about 4 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49290

#8 Updated by Bjoern Jacob about 4 years ago

  • Sprint Focus set to On Location Sprint

#9 Updated by Bjoern Jacob about 4 years ago

  • Status changed from Under Review to Resolved

#10 Updated by Benni Mack about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF