Story #76896
closed
Epic #76862: Refactor and modernise the TypoScript content renderer
Move stdWrap processing from ContentObjectRenderer into a separate class
0%
Description
To reduce the complexity of the giant class, move stdWrap processing from ContentObjectRenderer into a separate class.
Data types, functions and content objects are different parts of TypoScript. Following the principles of separation of concerns the different concerns should be moved out of ContentObjectRenderer step by step.
As stdWrap make a big part of ContentObjectRenderer let's start with this.
This is the plan:
- Adding unit test for stdWrap methods to create a safety net for the migration: Story #74496
- Creating a dedicated class for stdWrap and set up the initial infrastructure, tests etc.
- Moving the stdWrap methods step by step.
- Moving the rest of the stdWrap functionality.
Once the split into two classes is done, it's to consider to make every stdWrap a dedicated class: #68733
Challenge:
Both classes need to share a common data model. This is the current $data array of ContentObjectRenderer. The first idea may be, to use a reference, but as this property is public it may be changed from outside, what would break a reference.
A clean object orientated approach would be, to make the internal data representation of the ContentObjectRenderer private, maybe using an object, that is shared between both classes.
For the beginning a data access method will do. instead of working on a reference it will question the original property each time it is called.
The final solution still needs research.
Updated by Gerrit Code Review almost 8 years ago
- Status changed from New to Under Review
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 9 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 10 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 11 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 12 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 13 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 14 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 15 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 16 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 17 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 18 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 19 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 20 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 21 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 22 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 23 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 24 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 25 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 26 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Riccardo De Contardi almost 8 years ago
- Category set to Code Cleanup
Updated by Gerrit Code Review almost 8 years ago
Patch set 27 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 28 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 29 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 30 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 31 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Gerrit Code Review almost 8 years ago
Patch set 32 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48753
Updated by Benni Mack almost 6 years ago
- Status changed from Under Review to Closed