Project

General

Profile

Actions

Bug #76919

closed

Flaky references in TypoScript parsing

Added by Oliver Hader almost 8 years ago. Updated almost 8 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
TypoScript
Target version:
-
Start date:
2016-07-02
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
nightmare
Is Regression:
Yes
Sprint Focus:

Description

With issue #76323 a mysterious relic from the past has been removed which was about an explicit unserialize(serialize(...)) call during the TypoScript parsing process. In the TYPO3 backend it is possible to trigger some flaky behavior that interferes with those unresolved references.

Expect the following TSconfig as given:

RTE.default.proc.entryHTMLparser_db = 1
RTE.default.proc.entryHTMLparser_db {
    tag {
    }

RTE.default.FE < RTE.default
RTE.default.enableWordClean = 1
RTE.default.enableWordClean.HTMLparser < RTE.default.proc.entryHTMLparser_db

After the TypoScript has been parsed into an array, and the value
$data['RTE.']['default.']['FE.']['proc.']['entryHTMLparser_db.']['tags.'] is set to a different value, also the the value of ['RTE.']['default.']['proc.']['entryHTMLparser_db.']['tags.'] is changed due to the existing reference.

It was not able to reproduce this behavior in a dedicated functional test, but in the backend with BackendUtility::getPagesTSconfig and the accordant parsing part there.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #76323: Obsolete unserialize(serialize())Closed2016-05-27

Actions
Actions #1

Updated by Gerrit Code Review almost 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48777

Actions #2

Updated by Oliver Hader almost 8 years ago

There are several options to continue here:
  • try to reproduce in a stand-alone functional test
  • revert the change introduced with #76323
  • resolve the function calls by reference in TypoScriptParser
Actions #3

Updated by Gerrit Code Review almost 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48777

Actions #5

Updated by Gerrit Code Review almost 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48777

Actions #6

Updated by Gerrit Code Review almost 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48777

Actions #7

Updated by Gerrit Code Review almost 8 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48777

Actions #8

Updated by Gerrit Code Review almost 8 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48777

Actions #9

Updated by Oliver Hader almost 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #10

Updated by Gerrit Code Review almost 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49048

Actions #11

Updated by Oliver Hader almost 8 years ago

  • Status changed from Under Review to Resolved
Actions #12

Updated by Gerrit Code Review almost 8 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_8-2 of project Teams/Security/TYPO3v4-Core has been pushed to the review server.
It is available at https://review.typo3.org/49053

Actions #13

Updated by Wouter Wolters almost 8 years ago

  • Status changed from Under Review to Closed
Actions

Also available in: Atom PDF