Project

General

Profile

Actions

Bug #77008

closed

Epic #73121: Render() method arguments should be moved to initializeArguments()

Task #76914: Move method arguments to initializeArguments() in ext:fluid

StripTagsViewHelperTest: Move method arguments to initializeArguments() in ext:fluid

Added by Ivaylo Ivanov almost 8 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2016-07-10
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:
On Location Sprint

Description

Spliting Ticket #76914 due to have two developers work on different parts.
sysext/fluid/Tests/Unit/ViewHelpers/Format/StripTagsViewHelperTest.php:79: $actualResult = $this->viewHelper->render($source, $allowed);
sysext/fluid/Tests/Unit/ViewHelpers/Format/StripTagsViewHelperTest.php:89: $actualResult = $this->viewHelper->render($source);

new line:
sysext/fluid/Classes/ViewHelpers/Format/StripTagsViewHelper.php:68: public function render($value = null, $allowedTags = null)

Actions #1

Updated by Gerrit Code Review almost 8 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48876

Actions #2

Updated by Anja Leichsenring almost 8 years ago

  • Parent task set to #76914
Actions #3

Updated by Ivaylo Ivanov almost 8 years ago

  • Status changed from Under Review to In Progress
  • Assignee set to Ivaylo Ivanov
Actions #4

Updated by Gerrit Code Review almost 8 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48893

Actions #5

Updated by Ivaylo Ivanov almost 8 years ago

  • Assignee changed from Ivaylo Ivanov to Anja Leichsenring
  • % Done changed from 0 to 50
Actions #6

Updated by Ivaylo Ivanov almost 8 years ago

  • Description updated (diff)
Actions #7

Updated by Ivaylo Ivanov almost 8 years ago

  • Status changed from Under Review to In Progress
  • Assignee changed from Anja Leichsenring to Ivaylo Ivanov
Todo:
  1. add the patch for the main class
Actions #8

Updated by Gerrit Code Review almost 8 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48895

Actions #9

Updated by Ivaylo Ivanov almost 8 years ago

  • % Done changed from 50 to 100
Actions #10

Updated by Gerrit Code Review almost 8 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48896

Actions #11

Updated by Gerrit Code Review almost 8 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48897

Actions #12

Updated by Gerrit Code Review almost 8 years ago

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48898

Actions #13

Updated by Gerrit Code Review almost 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48898

Actions #14

Updated by Gerrit Code Review almost 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/48898

Actions #15

Updated by Ivaylo Ivanov almost 8 years ago

  • Status changed from Under Review to Resolved
Actions #16

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF