Task #77128

Epic #73121: Render() method arguments should be moved to initializeArguments()

Task #76914: Move method arguments to initializeArguments() in ext:fluid

CshViewHelper: Move method arguments to initializeArguments() in ext:fluid

Added by Roberto Torresani over 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Category:
Code Cleanup
Target version:
-
Start date:
2016-07-16
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Sprint Focus:
On Location Sprint

Description

sysext/fluid/Classes/ViewHelpers/Be/Buttons/CshViewHelper.php:60: public function render($table = null, $field = '', $wrap = '')

Associated revisions

Revision defb4df1 (diff)
Added by Roberto Torresani over 3 years ago

[TASK] Move arguments to initializeArguments() in CshVH in ext:fluid

Move the argument registrations away from the render() method
to initializeArguments(), to prevent any errors with PHP7 and
subclassed ViewHelpers if/when render() method signatures change.

Resolves: #77128
Releases: master
Change-Id: If7c6fb33a9464075e749b994381f1358cd5664d7
Reviewed-on: https://review.typo3.org/49005
Tested-by: Bamboo TYPO3com <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Joerg Boesche <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

Revision a897a5d7 (diff)
Added by Markus Friedrich over 3 years ago

[FOLLOWUP][TASK] Move arguments to initializeArguments() in CshVH

Patch adds missing parent::initializeArguments() call and removes
unneeded variable initializations

Resolves: #77128
Releases: master
Change-Id: If3ec88ccd7b73ab39544bc710823377af8ded128
Reviewed-on: https://review.typo3.org/49093
Reviewed-by: Johannes Bernhard Goslar <>
Tested-by: Johannes Bernhard Goslar <>
Tested-by: Bamboo TYPO3com <>
Reviewed-by: Steven Cardoso <>
Tested-by: Steven Cardoso <>
Reviewed-by: Nicole Cordes <>
Tested-by: Nicole Cordes <>

History

#1 Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49005

#2 Updated by Riccardo De Contardi over 3 years ago

  • Category set to Code Cleanup

#3 Updated by Roberto Torresani over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49093

#5 Updated by Markus Friedrich over 3 years ago

  • Status changed from Under Review to Resolved

#6 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF