Bug #77238
closedplaceholder attribute is only rendered if sword is empty
100%
Description
The search form renders the placeholder HTML5 attribute only if the form is called/submitted without any search words.
Steps to reproduce¶
- submit search form with a search word
- empty search text input field without re-submitting the form
Current behaviour¶
Placeholder does not show unless search form is called without any search word.
Expected behaviour¶
Upon clearing the field, placeholder should immediately become visible on HTML5, i.e. placeholder attribute should be present regardless of whether sword is empty or not.
Solution¶
The required patch is trivial (just move placeholder marker definition out of empty
condition) and will be attached or committed for review in a few minutes. Placeholders don't seem to be used in TYPO3 8 any more, so the issue applies only to TYPO3 7 and below.
Updated by Gerrit Code Review over 8 years ago
- Status changed from New to Under Review
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49186
Updated by Daniel Neugebauer over 8 years ago
TYPO3 6.2 does not appear to be using the same code if the problem exists there as well (not seeing where ###PLACEHOLDER### is being set...), so I guess fixing the issue for 7 should be sufficient.
Updated by Daniel Neugebauer over 8 years ago
If it's possible and necessary to somehow move the issue to a 7_6 indexed_search topic (appearing in Gerrit with EXT:indexed_search as "topic" attribute), I would be glad if someone could move it for me or - even better - document how that would be done. I can't find any documentation if that's even possible...
Updated by Gerrit Code Review about 8 years ago
Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49186
Updated by Gerrit Code Review about 8 years ago
Patch set 3 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49186
Updated by Anonymous about 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset e525591f02c9444d29d7deadbdc3534669818de9.