Bug #77238

placeholder attribute is only rendered if sword is empty

Added by Daniel Neugebauer over 2 years ago. Updated about 2 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Indexed Search
Target version:
-
Start date:
2016-07-25
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
no-brainer
Is Regression:
No
Sprint Focus:
On Location Sprint

Description

The search form renders the placeholder HTML5 attribute only if the form is called/submitted without any search words.

Steps to reproduce

  1. submit search form with a search word
  2. empty search text input field without re-submitting the form

Current behaviour

Placeholder does not show unless search form is called without any search word.

Expected behaviour

Upon clearing the field, placeholder should immediately become visible on HTML5, i.e. placeholder attribute should be present regardless of whether sword is empty or not.

Solution

The required patch is trivial (just move placeholder marker definition out of empty condition) and will be attached or committed for review in a few minutes. Placeholders don't seem to be used in TYPO3 8 any more, so the issue applies only to TYPO3 7 and below.

Associated revisions

Revision e525591f (diff)
Added by Daniel Neugebauer about 2 years ago

[BUGFIX] indexed_search renders HTML5 placeholder regardless of sword

If DocType is HTML5, placeholder attribute on sword input field is now
rendered regardless of sword being empty or not.

Resolves: #77238
Releases: 7.6
Change-Id: If9b31331e7941e5c9068f6f3e73d448fab4905cd
Reviewed-on: https://review.typo3.org/49186
Reviewed-by: Dmitry Dulepov <>
Tested-by: Dmitry Dulepov <>
Tested-by: TYPO3com <>
Reviewed-by: Jan Helke <>
Tested-by: Jan Helke <>

History

#1 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49186

#2 Updated by Daniel Neugebauer over 2 years ago

TYPO3 6.2 does not appear to be using the same code if the problem exists there as well (not seeing where ###PLACEHOLDER### is being set...), so I guess fixing the issue for 7 should be sufficient.

#3 Updated by Daniel Neugebauer over 2 years ago

If it's possible and necessary to somehow move the issue to a 7_6 indexed_search topic (appearing in Gerrit with EXT:indexed_search as "topic" attribute), I would be glad if someone could move it for me or - even better - document how that would be done. I can't find any documentation if that's even possible...

#4 Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49186

#5 Updated by Gerrit Code Review about 2 years ago

Patch set 3 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49186

#6 Updated by Jan Helke about 2 years ago

  • Sprint Focus set to On Location Sprint

#7 Updated by Anonymous about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8 Updated by Benni Mack about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF