placeholder attribute is only rendered if sword is empty
The search form renders the placeholder HTML5 attribute only if the form is called/submitted without any search words.
Steps to reproduce¶
- submit search form with a search word
- empty search text input field without re-submitting the form
Placeholder does not show unless search form is called without any search word.
Upon clearing the field, placeholder should immediately become visible on HTML5, i.e. placeholder attribute should be present regardless of whether sword is empty or not.
The required patch is trivial (just move placeholder marker definition out of
empty condition) and will be attached or committed for review in a few minutes. Placeholders don't seem to be used in TYPO3 8 any more, so the issue applies only to TYPO3 7 and below.
[BUGFIX] indexed_search renders HTML5 placeholder regardless of sword
If DocType is HTML5, placeholder attribute on sword input field is now
rendered regardless of sword being empty or not.
Reviewed-by: Dmitry Dulepov <firstname.lastname@example.org>
Tested-by: Dmitry Dulepov <email@example.com>
Tested-by: TYPO3com <firstname.lastname@example.org>
Reviewed-by: Jan Helke <email@example.com>
Tested-by: Jan Helke <firstname.lastname@example.org>
#3 Updated by Daniel Neugebauer over 2 years ago
If it's possible and necessary to somehow move the issue to a 7_6 indexed_search topic (appearing in Gerrit with EXT:indexed_search as "topic" attribute), I would be glad if someone could move it for me or - even better - document how that would be done. I can't find any documentation if that's even possible...