Project

General

Profile

Actions

Bug #77471

closed

Template module got wrong markup

Added by Georg Ringer almost 8 years ago. Updated almost 7 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
Start date:
2016-08-10
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

After #75028 the template module regarding "info/update" is broken. If no template record is on the selected page, most text is not there because the translate VH got no extkey set and there is even a todo in the code

// @TODO: not sure this should stay; this value should in any case be a *proper* extension name!
        $view->getRequest()->setControllerExtensionName('web_ts');

If this is changed, the markup is even worse

<form action="/typo3/index.php?M=web_ts&amp;moduleToken=3d1a0b2ae58280eb53ec26d26f5aed77ab4c7f3a&amp;id=12&amp;template=all" method="post" enctype="multipart/form-data" id="TypoScriptTemplateModuleController" name="editForm" class="form">
    <h1>Template tools</h1>
    
    <form action="" method="post" enctype="multipart/form-data" id="TypoScriptTemplateModuleController" name="editForm" class="form">
    <h1>Template tools</h1>
    <form action="" method="post" enctype="multipart/form-data" id="TypoScriptTemplateModuleController" name="editForm" class="form">

there are then 2 h1 tags and 3 inline form tags, so there is something really wrong


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Task #75028: Fluidification of TypoScriptTemplateModuleControllerClosedMichael Oehlhof2016-03-12

Actions
Actions #1

Updated by Gerrit Code Review almost 8 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49455

Actions #2

Updated by Gerrit Code Review almost 8 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49455

Actions #3

Updated by Gerrit Code Review almost 8 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49455

Actions #4

Updated by Gerrit Code Review almost 8 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49455

Actions #5

Updated by Michael Oehlhof almost 8 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Riccardo De Contardi almost 7 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF