Bug #77471
closedTemplate module got wrong markup
100%
Description
After #75028 the template module regarding "info/update" is broken. If no template record is on the selected page, most text is not there because the translate VH got no extkey set and there is even a todo in the code
// @TODO: not sure this should stay; this value should in any case be a *proper* extension name! $view->getRequest()->setControllerExtensionName('web_ts');
If this is changed, the markup is even worse
<form action="/typo3/index.php?M=web_ts&moduleToken=3d1a0b2ae58280eb53ec26d26f5aed77ab4c7f3a&id=12&template=all" method="post" enctype="multipart/form-data" id="TypoScriptTemplateModuleController" name="editForm" class="form"> <h1>Template tools</h1> <form action="" method="post" enctype="multipart/form-data" id="TypoScriptTemplateModuleController" name="editForm" class="form"> <h1>Template tools</h1> <form action="" method="post" enctype="multipart/form-data" id="TypoScriptTemplateModuleController" name="editForm" class="form">
there are then 2 h1 tags and 3 inline form tags, so there is something really wrong
Updated by Gerrit Code Review over 8 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49455
Updated by Gerrit Code Review over 8 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49455
Updated by Gerrit Code Review over 8 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49455
Updated by Gerrit Code Review over 8 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49455
Updated by Michael Oehlhof over 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b1902e24750fec25196e9b6e01b03187a0ff7c45.
Updated by Riccardo De Contardi about 7 years ago
- Status changed from Resolved to Closed