Task #77502

Remove preparsing of queries

Added by Benni Mack over 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Extbase
Target version:
Start date:
2016-08-15
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Sprint Focus:

Related issues

Related to TYPO3 Core - Task #75545: Doctrine DBAL migration Closed 2016-04-12

Associated revisions

Revision e33966d1 (diff)
Added by Benni Mack over 2 years ago

[!!!][TASK] Extbase: Remove preparsing of queries

The whole concept of having placeholders is a pseudo-prepared
statement idea, which RDBMS do inside their query cache. The logic
inside PHP is therefore removed.

The following public methods have been removed:
  • Typo3DbBackend->quoteTextValueCallback()
  • Typo3DbQueryParser->preparseQuery()
  • Typo3DbQueryParser->normalizeParameterIdentifier()
  • Typo3DbQueryParser->addDynamicQueryParts()
  • ComparisonInterface->setParameterIdentifier
  • ComparisonInterface->getParameterIdentifier
The following methods have been marked as deprecated:
  • Comparison->setParameterIdentifier()
  • Comparison->getParameterIdentifier()

This patch is one of the prerequisites to introduce the Doctrine DBAL
QueryBuilder instead of building raw SQL statements.

Resolves: #77502
Releases: master
Change-Id: Ia5be0148874c15337ab5ce60094e9eae72fe3d9e
Reviewed-on: https://review.typo3.org/49470
Tested-by: Bamboo TYPO3com <>
Reviewed-by: Oliver Hader <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49470

#2 Updated by Benni Mack over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#3 Updated by Riccardo De Contardi over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF