Bug #77529

Epic #73121: Render() method arguments should be moved to initializeArguments()

Move missing method arguments to initializeArguments() in ext:fluid

Added by Nicole Cordes over 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
-
Start date:
2016-08-17
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Currently 3 ViewHelpers miss the moving of method arguments to initializeArguments().

- \TYPO3\CMS\Fluid\ViewHelpers\Be\Buttons\ShortcutViewHelper
- \TYPO3\CMS\Fluid\ViewHelpers\Link\EmailViewHelper
- \TYPO3\CMS\Fluid\ViewHelpers\Link\ExternalViewHelper
- \TYPO3\CMS\Fluid\ViewHelpers\Link\TypolinkViewHelper::initializeArguments

Associated revisions

Revision d254f834 (diff)
Added by Nicole Cordes over 3 years ago

[TASK] Move render arguments to initializeArguments()

Move the argument registrations away from the render() method
to initializeArguments() of the last missing ViewHelpers of EXT:fluid.

Resolves: #77529
Releases: master
Change-Id: I4113f17b19a2883f23c62dc5bd3779f8640d4f97
Reviewed-on: https://review.typo3.org/49501
Tested-by: Bamboo TYPO3com <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>
Reviewed-by: Stefan Neufeind <>
Tested-by: Stefan Neufeind <>
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>

Revision 97416e98 (diff)
Added by Georg Ringer over 3 years ago

[FOLLOWUP][TASK] Move render arguments to initializeArguments()

Readd the method 'render' to the ShortcutViewHelper

Resolves: #77529
Releases: master
Change-Id: I01bdd78e51a4b28d7caf89207982d99d66c59ff6
Reviewed-on: https://review.typo3.org/49580
Reviewed-by: Wouter Wolters <>
Tested-by: Wouter Wolters <>
Tested-by: Bamboo TYPO3com <>
Reviewed-by: Stefan Neufeind <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

History

#1 Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49501

#2 Updated by Nicole Cordes over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#3 Updated by Gerrit Code Review over 3 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49580

#4 Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/49580

#5 Updated by Georg Ringer over 3 years ago

  • Status changed from Under Review to Resolved

#6 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF