Project

General

Profile

Actions

Bug #78376

closed

Install Tool - Core update - Unstyled progress messages

Added by Horst Wiederhold over 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Install Tool
Target version:
-
Start date:
2016-10-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
5.6
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

During and after a successful core update in the install tool a few messages are unstyled:

  • TYPO3 CMS core download finished
  • Checksum verified
  • Unpacking TYPO3 CMS core successful
  • Moved TYPO3 CMS core to final location

All four messages are styled with the css-class alert-ok which is not present in typo3\sysext\install\Resources\Public\Css\InstallTool.css.

In typo3\sysext\install\Classes\Service\CoreUpdateService.php are four coresponding calls of "$message = GeneralUtility::makeInstance(OkStatus::class);".

When setting protected $severity = 'ok'; to protected $severity = 'success'; in typo3\sysext\install\Classes\Status\OkStatus.php the four messages get the class alert-success and are styled correct.

Maybe this is a side-effect of [[https://forge.typo3.org/issues/71374]].


Files

Actions #1

Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50447

Actions #2

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50447

Actions #3

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50447

Actions #4

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50553

Actions #5

Updated by Gerrit Code Review over 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50553

Actions #6

Updated by Gerrit Code Review over 7 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50599

Actions #7

Updated by Frank Nägler over 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF