Project

General

Profile

Actions

Bug #78741

closed

FileCollector::addFilesFromRelation missing check for already overlayed pages

Added by Frank Nägler over 7 years ago. Updated over 7 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
-
Target version:
Start date:
2016-11-18
Due date:
% Done:

0%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

Adding file references to a translated page currently fails due to double overlaying of the pages record.
Add a check to resolve the references directly, if the page has already been overlayed, should solves the problem.

To reproduce this bug, you can use the following TypoScript:


temp.listItem = FILES
temp.listItem {
   references {
      table = pages
      fieldName = navigation_icon
   }

   maxItems = 1
   renderObj = COA
   renderObj {
      10 = IMAGE
      10 {
         params = class="img-circle" 
         file {
            import.data = file:current:uid
            treatIdAsReference = 1
            width = 40
            height = 40
         }
      }

      20 = TEXT
      20.field = nav_title // title

      stdWrap.typolink {
         parameter.field = uid
      }
   }
}

lib.navigationSecondLevel = HMENU
lib.navigationSecondLevel {
   special = directory
   special.value.current = 1
   1 = TMENU
   1 {
      noBlur = 1
      wrap = <ul class="list-unstyled">|</ul>
      expAll = 1
      NO = 1
      NO.ATagTitle.field = nav_title // title
      NO.stdWrap.cObject < temp.listItem
      NO.doNotLinkIt = 1
      NO.wrapItemAndSub = <li>|</li>
   }
}

This TypoScript generates a menu with an icon/image resolved from the media field.
This works well for the default language, but not for any translated page.

The field navigation_icon is not translatable, it is set only in the default language


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #78743: Wrong translation behavior for pages/pages_language_overlayRejected2016-11-18

Actions
Actions #1

Updated by Frank Nägler over 7 years ago

  • Description updated (diff)
Actions #2

Updated by Gerrit Code Review over 7 years ago

  • Status changed from In Progress to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50704

Actions #3

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50704

Actions #4

Updated by Frank Nägler over 7 years ago

  • Description updated (diff)
Actions #5

Updated by Frank Nägler over 7 years ago

  • Status changed from Under Review to Closed

no bug, TCA missconfiguration

Actions

Also available in: Atom PDF