Bug #78986
closedDefault TCA configuration breaks sys_file_reference sorting_foreign
100%
Description
The "sorting_foreign" used to sort inline sys_file_reference records, handles the sorting by using integers like 1,2,3,4,5...
The field "sorting_foreign" is configured in the core as:
'sorting_foreign' => [ ... 'config' => [ 'type' => 'input', ... 'range' => [ 'upper' => '1000', 'lower' => '10' ] ... ] ]
Saving operations in the backend can therefore result in all "sorting_foreign" values < 10 being set to 10 (because of the range setting), which breaks the sorting!
This issue wasnt easy to reproduce, for me it appeared by sorting inline images in the live workspace (resulting in "correct" sorting_foreign values), then making changes to other inline images in the draft workspace (resulting in all sorting "foreign_values" being set to 10).
The fix should be easy by just removing the range constraint completely from the sys_file_reference TCA configuration (i appended a diff file).
Files
Updated by Matthias Kümpel almost 8 years ago
- Subject changed from Defalt TCA configuration breaks sys_file_reference sorting_foreign to Default TCA configuration breaks sys_file_reference sorting_foreign
Updated by Gerrit Code Review almost 8 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51001
Updated by Gerrit Code Review almost 8 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51001
Updated by Georg Ringer almost 8 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 6e0aa6a57f5da8e12d2f057321ba4d487ce99cad.
Updated by Gerrit Code Review almost 8 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51227
Updated by Georg Ringer almost 8 years ago
- Status changed from Under Review to Resolved
Applied in changeset 3376cab4f2a922cd7638115d7ac55fc6d7268ed9.
Updated by Gerrit Code Review almost 8 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51284
Updated by Georg Ringer almost 8 years ago
- Status changed from Under Review to Resolved
Applied in changeset b236079f17ef9449a6a124a8fd67247114684d8f.