Project

General

Profile

Actions

Bug #78986

closed

Default TCA configuration breaks sys_file_reference sorting_foreign

Added by Matthias Kümpel over 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
File Abstraction Layer (FAL)
Target version:
-
Start date:
2016-12-14
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
easy
Is Regression:
No
Sprint Focus:

Description

The "sorting_foreign" used to sort inline sys_file_reference records, handles the sorting by using integers like 1,2,3,4,5...

The field "sorting_foreign" is configured in the core as:

        'sorting_foreign' => [
            ...
            'config' => [
                'type' => 'input',
               ...
                'range' => [
                    'upper' => '1000',
                    'lower' => '10'
                ]
               ...
            ]
        ]

Saving operations in the backend can therefore result in all "sorting_foreign" values < 10 being set to 10 (because of the range setting), which breaks the sorting!

This issue wasnt easy to reproduce, for me it appeared by sorting inline images in the live workspace (resulting in "correct" sorting_foreign values), then making changes to other inline images in the draft workspace (resulting in all sorting "foreign_values" being set to 10).

The fix should be easy by just removing the range constraint completely from the sys_file_reference TCA configuration (i appended a diff file).


Files

sys_file_reference.diff (143 Bytes) sys_file_reference.diff Matthias Kümpel, 2016-12-14 10:42
Actions #1

Updated by Matthias Kümpel over 7 years ago

  • Subject changed from Defalt TCA configuration breaks sys_file_reference sorting_foreign to Default TCA configuration breaks sys_file_reference sorting_foreign
Actions #2

Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51001

Actions #3

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51001

Actions #4

Updated by Georg Ringer over 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Gerrit Code Review over 7 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51227

Actions #6

Updated by Georg Ringer over 7 years ago

  • Status changed from Under Review to Resolved
Actions #7

Updated by Gerrit Code Review over 7 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51284

Actions #8

Updated by Georg Ringer over 7 years ago

  • Status changed from Under Review to Resolved
Actions #9

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF