Bug #78995

label_alt-parts of record titles are displayed rawurlencoded() since TYPO3 7

Added by Stephan Großberndt almost 2 years ago. Updated 2 months ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
FormEngine aka TCEforms
Target version:
-
Start date:
2016-12-14
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
Yes
Sprint Focus:

Description

Since TYPO3 7 there is a bug displaying the record title. This issue contains a test-extension to verify it.

The problem is the record title referenced in label_alt from another table. In TYPO3 6.2 the record title is displayed correctly, in TYPO3 7.6 the label parts from other tables are rawurlencoded.

To verify the issue install the extension and add test records:

INSERT INTO tx_test_a VALUES (1,1,'Äther', 1);
INSERT INTO tx_test_b VALUES (1,1,'Äther', 1);
INSERT INTO tx_test_c VALUES (1,1,'Äther');

If you open tx_test_a:1 now, in TYPO3 7.6 the record title is partly rawurlencoded, in TYPO3 6.2 its fine.

Wrong on TYPO3 7.6

Correct on TYPO3 6.2

As it seems for internal handling (probably in relation to inline editing), formengine needs rawurlencode() on internal record references:

typo3/sysext/backend/Classes/Form/FormDataProvider/TcaGroup.php

$result['databaseRow'][$fieldName] = $relationHandler->readyForInterface();

The method \TYPO3\CMS\Backend\Form\FormDataProvider\TcaRecordTitle::getRecordTitleForGroupType() used to render the displayed title should rawurldecode() the title.

test.zip - Test-Extension (2.74 KB) Stephan Großberndt, 2016-12-14 17:11

wrong_on_typo3_76.png View - Wrong on TYPO3 7.6 (12 KB) Stephan Großberndt, 2016-12-14 17:11

correct_on_typo3_62.png View - Correct on TYPO3 6.2 (8.08 KB) Stephan Großberndt, 2016-12-14 17:11

Associated revisions

Revision 377bdaae (diff)
Added by Oliver Hader 10 months ago

[BUGFIX] Do not rawurlencode record titles using label_alt and type=group

Do not rawurlencode the label_alt part references of record titles if
they are of type=group as this leads to duplicate encoding.

Resolves: #78995
Releases: 7.6
Change-Id: I9a445745415080856adfbf51c4a87820a8e77375
Reviewed-on: https://review.typo3.org/54483
Reviewed-by: Mathias Schreiber <>
Tested-by: Mathias Schreiber <>
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

History

#1 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/50959

#2 Updated by Gerrit Code Review about 1 year ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54483

#3 Updated by Gerrit Code Review 10 months ago

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54483

#4 Updated by Oliver Hader 10 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#5 Updated by Benni Mack 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF