Project

General

Profile

Actions

Bug #79045

closed

getTemplatePathAndFilename() in \TYPO3\CMS\Fluid\View\StandaloneView calls a non existing method

Added by Daniel Lorenz over 7 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Fluid
Target version:
Start date:
2016-12-20
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The method getTemplatePathAndFilename() in \TYPO3\CMS\Fluid\View\StandaloneView calls getTemplatePathAndFilename() on the TemplatePath. But this method doesn't exist neither in \TYPO3\CMS\Fluid\View\TemplatePaths nor in \TYPO3Fluid\Fluid\View\TemplatePaths

    /**
     * Returns the absolute path to a Fluid template file if it was specified with setTemplatePathAndFilename() before
     *
     * @return string Fluid template path
     * @api
     */
    public function getTemplatePathAndFilename()
    {
        return $this->baseRenderingContext->getTemplatePaths()->getTemplatePathAndFilename();
    }

I had a conversation with Claus on Slack. He don't wan't to reimplement this method in \TYPO3Fluid\Fluid\View\TemplatePaths. He also will deprecate the setTemplatePathAndFilename() method there.

I think there are two solutions:
  1. reimplement the getter-method in \TYPO3\CMS\Fluid\View\TemplatePaths
  2. remove the getter in \TYPO3\CMS\Fluid\View\StandaloneView

The second solution will be a breaking change in TYPO3 v8.

We should find a solution for that and mark both (getTemplatePathAndFilename() and setTemplatePathAndFilename()) as deprecated.

Actions #1

Updated by Daniel Lorenz over 7 years ago

  • Assignee set to Daniel Lorenz
Actions #2

Updated by Gerrit Code Review over 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51004

Actions #3

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51004

Actions #4

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51004

Actions #5

Updated by Gerrit Code Review over 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51004

Actions #6

Updated by Gerrit Code Review over 7 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51004

Actions #7

Updated by Gerrit Code Review over 7 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51004

Actions #8

Updated by Daniel Lorenz over 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #9

Updated by Riccardo De Contardi over 6 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF