Bug #79156: Wrong translation behavior for file references fields in pages/pages_language_overlay with l10n_mode = exclude - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #79156

closed

Wrong translation behavior for file references fields in pages/pages_language_overlay with l10n_mode = exclude

Added by Frans Saris over 7 years ago. Updated almost 5 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Localization

Target version:

Start date:

2017-01-04

Due date:

% Done:

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

When you don't define a field in pages_language_overlay because the field is defined as l10n_mode = exclude in pages the PageRepository::shouldFieldBeOverlaid() wrongly sees the field as being overlayed.

All methods calling PageRepository::shouldFieldBeOverlaid() respect $GLOBALS['TYPO3_CONF_VARS']['FE']['pageOverlayFields'] already before calling it except PageRepository::getFileReferences() where it now goes wrong when fetching files for the field of a translated page.

Example ts to test:

page.111 = FILES
page.111 {
    references {
        table = pages
        fieldName = my_custom_field
    }

    renderObj = IMAGE
    renderObj {
        file.import.data = file:current:uid
        file.treatIdAsReference = 1
        altText.data = file:current:title
        wrap = <li>|</li>
    }

    stdWrap.wrap = <ul>|</ul>
}

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51116

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51116

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51116

Actions

Copy link

Updated by Frans Saris over 7 years ago

Subject changed from Wrong translation behavior for pages/pages_language_overlay of l10n_mode = exclude to Wrong translation behavior for file references fields in pages/pages_language_overlay with l10n_mode = exclude
Description updated (diff)

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51116

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51116

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51116

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51116

Actions

Copy link

Updated by Gerrit Code Review about 7 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51827

Actions

Copy link

#10