Bug #79166

Wrong parameter type in LinkAnalyzer causes exception

Added by Christer V almost 3 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Category:
Linkvalidator
Target version:
-
Start date:
2017-01-05
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

How to replicated: Run Linkvalidator somewhere that already has broken link. When trying to delete the previous broken links you get a exception.

To fix:

In TYPO3\CMS\Linkvalidator\LinkAnalyzer::getLinkStatistics

$queryBuilder->expr()->in(
    'link_type',
    $queryBuilder->createNamedParameter($checkKeys, Connection::PARAM_INT_ARRAY)
)

Should be changed to
$queryBuilder->expr()->in(
    'link_type',
    $queryBuilder->createNamedParameter($checkKeys, Connection::PARAM_STR_ARRAY)
)

Tested in T3 8.5.1. PHP 7. MySQL 5.7

Associated revisions

Revision d827be67 (diff)
Added by Georg Ringer almost 3 years ago

[BUGFIX] Use proper type in LinkAnalyzer to avoid exceptions

To avoid exceptions, the proper type must be used.

Resolves: #79166
Releases: master
Change-Id: I00a6d65bee8b8807853461bfad681f354ae02045
Reviewed-on: https://review.typo3.org/51319
Tested-by: TYPO3com <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Joerg Boesche <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>

History

#1 Updated by Morton Jonuschat almost 3 years ago

  • Assignee set to Morton Jonuschat

#2 Updated by Gerrit Code Review almost 3 years ago

  • Status changed from New to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51319

#3 Updated by Georg Ringer almost 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF