Bug #79569: IRRE preview does not show a default icon when no preview rendering is possible - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #79569

open

IRRE preview does not show a default icon when no preview rendering is possible

Added by Daniel Wagner about 7 years ago. Updated over 6 years ago.

Status:

New

Priority:

Must have

Assignee:

Category:

Image Generation / GIFBUILDER

Target version:

Start date:

2017-01-31

Due date:

% Done:

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

image security backend irre

Complexity:

easy

Is Regression:

Sprint Focus:

Description

Scenario
A user adds a CE upload ("File Links") to a page and adds e.g. some files with extension .xls and .pdf.

Problem
The preview rendered within IRRE does not work for all allowed fileextensions - see attachment.
The thumbnail rendering of PDF is working correctly in module filelist - see attachment.

although thumbnail generation for PDF is working a default icon shown - that is okay.
for XLS a preview does not make sense but is tried and no icon is shown - that looks odd.

Versions
TYPO3 CMS 7.6.15

Files

Download all files

filelist_preview_on.png (6.12 KB) filelist_preview_on.png	module filelist	Daniel Wagner, 2017-01-31 12:45
ce_filelist_references_preview.png (9.23 KB) ce_filelist_references_preview.png	CE upload	Daniel Wagner, 2017-01-31 12:45
ce_filelist_pagemodule.png (2.63 KB) ce_filelist_pagemodule.png	module page	Daniel Wagner, 2017-01-31 16:31
preview_1e8552bd43.gif.png (371 Bytes) preview_1e8552bd43.gif.png	preview image by graphicsmagick	Daniel Wagner, 2017-02-07 12:58

Actions

Copy link

Updated by Daniel Wagner about 7 years ago

File ce_filelist_pagemodule.png ce_filelist_pagemodule.png added

Actions

Copy link

Updated by Daniel Wagner about 7 years ago

File preview_1e8552bd43.gif.png preview_1e8552bd43.gif.png added

Actions

Copy link

Updated by Daniel Wagner about 7 years ago

Thumbnail Rendering
renderForeignRecordHeader in InlineRecordContainer.php lets the image tool render a preview
and then will show the thumbnail if the processedImage has any width otherwise an icon will be shown.

In my case graphicsmagick renders a gif-thumbnail containing some text infos which has a width :(

Suggestion
Instead checking the thumbnail generation afterwards there should be a check against [GFX][imagefile_ext] before the generation.

Side Effects

there wont be any PDF thumbnail if you do not allow PDFs as image (as suggested by TYPO3)
in matters of security it is better to render only images (there have been issues in the past, e.g. TYPO3-PSA-2016-001)

Actions

Copy link