Actions
Task #79870
closed
Check for wrong usage of Connection::errorCode()
Status:
Closed
Priority:
Must have
Assignee:
Category:
Database API (Doctrine DBAL)
Target version:
Start date:
2017-02-17
Due date:
% Done:
100%
Estimated time:
TYPO3 Version:
8
PHP Version:
7.1
Tags:
Complexity:
Sprint Focus:
Description
There are places in the core where we try to detect failed SQL statements based on the usage of Connection::errorCode().
This is not reliable and may lead to false positives, i.e. due to databases reporting an Errorcode of '00000' which isn't an actual error.
Doctrine throws an exception on failed statements, wrap statements in try/catch to get reliable feedback
Updated by Benni Mack over 7 years ago
- Target version changed from 8 LTS to Candidate for patchlevel
Updated by Gerrit Code Review over 7 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53130
Updated by Gerrit Code Review over 7 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53243
Updated by Morton Jonuschat over 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 445b001a5fa847824d8370e1d75276c80dfdb229.
Actions