Task #79870: Check for wrong usage of Connection::errorCode() - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Task #79870

closed

Check for wrong usage of Connection::errorCode()

Added by Morton Jonuschat about 7 years ago. Updated over 5 years ago.

Status:

Closed

Priority:

Must have

Assignee:

Morton Jonuschat

Category:

Database API (Doctrine DBAL)

Target version:

Candidate for patchlevel

Start date:

2017-02-17

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

7.1

Tags:

Complexity:

Sprint Focus:

Description

There are places in the core where we try to detect failed SQL statements based on the usage of Connection::errorCode().
This is not reliable and may lead to false positives, i.e. due to databases reporting an Errorcode of '00000' which isn't an actual error.

Doctrine throws an exception on failed statements, wrap statements in try/catch to get reliable feedback

Actions

Copy link

Updated by Benni Mack almost 7 years ago

Target version changed from 8 LTS to Candidate for patchlevel

Actions

Copy link

Updated by Gerrit Code Review almost 7 years ago

Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53130

Actions

Copy link

Updated by Gerrit Code Review almost 7 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53243

Actions

Copy link