Project

General

Profile

Actions
Copy link

Task #79870

closed

Check for wrong usage of Connection::errorCode()

Added by Morton Jonuschat almost 8 years ago. Updated about 6 years ago.

Status:
Closed
Priority:
Must have
Assignee:
Morton Jonuschat
Category:
Database API (Doctrine DBAL)
Target version:
Candidate for patchlevel
Start date:
2017-02-17
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.1
Tags:
Complexity:
Sprint Focus:

Description

There are places in the core where we try to detect failed SQL statements based on the usage of Connection::errorCode().
This is not reliable and may lead to false positives, i.e. due to databases reporting an Errorcode of '00000' which isn't an actual error.

Doctrine throws an exception on failed statements, wrap statements in try/catch to get reliable feedback

Actions
Copy link

Also available in: Atom PDF