Opening links in pop-up windows no longer works
After the rewrite of Css Styled Content, it's no longer possible to open links in pop up windows.How to replicate.
- Create a link
- Set a external link
- Set 500x500 as target
Expected behaviour is that the link opens in a new pop-up window with size 500x500. But currently the link just opens in a new tab.
The reason is that the typoscript was rewritten so that
parameter.data = parameters:allParams was changed to
parameter.data = parameters:href. This means that the link target doesn't get parsed by to
resolveMixedLinkParameter, which means that
TypoLinkCodecService->decode won't return the correct target.
[BUGFIX] Opening links in pop-up windows
Moved the check for if the target is coded as a JS open window link,
to a later stage in the function.
Since Css Styled Content and Fluid Styled Content was refactored,
the target might not be set until later in the typoLink
function. This caused pop links to stop working, moving the check for a
pop up link target to a later stages fixes the problem.
Tested-by: TYPO3com <firstname.lastname@example.org>
Reviewed-by: Anders Kostending <email@example.com>
Reviewed-by: Faton Haliti <firstname.lastname@example.org>
Reviewed-by: Jasmina Ließmann
Tested-by: Jasmina Ließmann <email@example.com>
Reviewed-by: Timo Hund <firstname.lastname@example.org>
Tested-by: Timo Hund <email@example.com>
Reviewed-by: Nicole Cordes <firstname.lastname@example.org>
Tested-by: Nicole Cordes <email@example.com>