Bug #80183

Backend requireJS paths are calculated wrongly for CLI.

Added by Christer V over 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Could have
Assignee:
-
Category:
-
Target version:
Start date:
2017-03-08
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

If after clearing all the cache the first hit to a typo3 installation is a cli command the backend requireJS paths are calculated and saved wrongly causing the backend to fail.

In computeRequireJsConfig the $fullJsPath is calculated to be '/typo3/sysext/core/Resources/Public/JavaScript/' instead of 'sysext/core/Resources/Public/JavaScript/'.

How to replicate:
Removed 'var/cache' run 'typo3/cli_dispatch.phpsh' visit backend.

Associated revisions

Revision f51ce1a4 (diff)
Added by Christer V over 2 years ago

[BUGFIX] Skip CKEditor registration on CLI

Made sure the CKEditor RequireJS paths are not calculated when running
in a CLI context.

When rte_ckeditor is installed, all caches are cleared
and the first hit to a TYPO3 installation is a CLI command, the
backend RequireJS paths are calculated and saved wrongly
causing the backend to fail afterwards.

How to replicate:

  • install rte_ckeditor
  • delete var/Cache/
  • run typo3/cli_dispatch.phpsh
  • visit backend

Resolves: #80183
Releases: master
Change-Id: I5de9462a6f577f2eb6c06adabe44a6a86e3c2592
Reviewed-on: https://review.typo3.org/51981
Reviewed-by: Mathias Brodala <>
Tested-by: Mathias Brodala <>
Reviewed-by: Anders Kostending <>
Tested-by: TYPO3com <>
Reviewed-by: Frank Nägler <>
Tested-by: Frank Nägler <>

Revision 89b986c4 (diff)
Added by Benni Mack over 2 years ago

[BUGFIX] Avoid CKEditor RequireJS information loaded in FE

The CKEditor default configuration for RequireJS path
resolving is only relevant in BE, Frontend Page Rendering
needs to do that separately for now, to avoid
loading of too many unnecessary config files if only
requireJS should be used in the Frontend.

The patch changes the functionality to only load
RequireJS in Backend (and not in CLI mode).

Resolves: #80183
Releases: master
Change-Id: I035ddb6bc83ebfb2a8f45de71fadd8f0e0b2d0a3
Reviewed-on: https://review.typo3.org/51987
Reviewed-by: Frank Nägler <>
Tested-by: TYPO3com <>
Reviewed-by: Tymoteusz Motylewski <>
Reviewed-by: Mathias Brodala <>
Reviewed-by: Christer V <>
Tested-by: Christer V <>
Reviewed-by: Andreas Fernandez <>
Tested-by: Andreas Fernandez <>

History

#1 Updated by Christer V over 2 years ago

  • Status changed from New to Rejected
  • Priority changed from Must have to Could have

#2 Updated by Christer V over 2 years ago

  • Status changed from Rejected to New

You have to have rte_ckeditor installed.

#3 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51981

#4 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51981

#5 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51981

#6 Updated by Christer V over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Gerrit Code Review over 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/51987

#8 Updated by Benni Mack over 2 years ago

  • Status changed from Under Review to Resolved

#9 Updated by Riccardo De Contardi about 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF