Bug #80385
closed
INCLUDE_TYPOSCRIPT is using wrong ConditionMatcher when using condition option
100%
Description
The INCLUDE_TYPOSCRIPT option does always use the Backend ConditionMatcher.
However, in FE this should be the Frontend ConditionMatcher because otherwise the current page might not be detected correctly.
Furthermore, constants also won't be available etc.
Updated by Gerrit Code Review about 7 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52114
Updated by Gerrit Code Review about 7 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52114
Updated by Gerrit Code Review about 7 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52114
Updated by Gerrit Code Review about 7 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52114
Updated by Gerrit Code Review about 7 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52114
Updated by Andreas Allacher about 7 years ago
To test the easiest way is probably to check for usergroup:
<INCLUDE_TYPOSCRIPT: source="FILE:EXT:..." condition="[usergroup = 1]">
Currently it will always check the usergroup of the Backenduser instead of the frontend user or backend user depending on the request.
It will might actually result in a PHP notice as $GLOBALS['BE_USER'] might not available in frontend.
Updated by Gerrit Code Review almost 7 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52114
Updated by Gerrit Code Review almost 7 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52114
Updated by Benni Mack almost 7 years ago
- Target version changed from 8 LTS to next-patchlevel
Updated by Gerrit Code Review almost 7 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52760
Updated by Gerrit Code Review almost 7 years ago
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52761
Updated by Anonymous almost 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 35fe85f378c9e2d2d0976e1ab0fdfe0327c339cc.