Project

General

Profile

Actions

Bug #80385

closed

INCLUDE_TYPOSCRIPT is using wrong ConditionMatcher when using condition option

Added by Andreas Allacher almost 7 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
TypoScript
Target version:
Start date:
2017-03-22
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
No
Sprint Focus:

Description

The INCLUDE_TYPOSCRIPT option does always use the Backend ConditionMatcher.
However, in FE this should be the Frontend ConditionMatcher because otherwise the current page might not be detected correctly.
Furthermore, constants also won't be available etc.


Related issues 1 (0 open1 closed)

Related to TYPO3 Core - Bug #76236: INCLUDE_TYPOSCRIPT condition PIDinRootline does not work correctyClosed2016-05-19

Actions
Actions #1

Updated by Gerrit Code Review almost 7 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52114

Actions #2

Updated by Gerrit Code Review almost 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52114

Actions #3

Updated by Gerrit Code Review almost 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52114

Actions #4

Updated by Gerrit Code Review almost 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52114

Actions #5

Updated by Gerrit Code Review almost 7 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52114

Actions #6

Updated by Andreas Allacher almost 7 years ago

To test the easiest way is probably to check for usergroup:
<INCLUDE_TYPOSCRIPT: source="FILE:EXT:..." condition="[usergroup = 1]">

Currently it will always check the usergroup of the Backenduser instead of the frontend user or backend user depending on the request.

It will might actually result in a PHP notice as $GLOBALS['BE_USER'] might not available in frontend.

Actions #7

Updated by Gerrit Code Review almost 7 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52114

Actions #8

Updated by Gerrit Code Review almost 7 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52114

Actions #9

Updated by Benni Mack almost 7 years ago

  • Target version changed from 8 LTS to next-patchlevel
Actions #10

Updated by Gerrit Code Review almost 7 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52760

Actions #11

Updated by Gerrit Code Review almost 7 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52761

Actions #12

Updated by Anonymous almost 7 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #13

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF