Bug #80459
closedMissing dependency of various require JS modules on FormEngineValidation
100%
Description
Some module require the requireJS module FormEngine. Those modules use the "submodule" FormEngine.Validation
in their initialization.
The problem is that FormEngine.Validation
is initialized in a separate requireJS module "FormEngineValidation", which itself depends on the FormEngine module to be available.
So for requireJS the dependency tree resolves to this:
FormEngine
- FormEngineValidation
- Editor
- ...
As by definition the loading and execution order of modules without dependency is undefined.
Since e.g. Editor specifies a dependency on FormEngine, but uses actually only FormEngineValidation, there can be race conditions, FormEngineValidation is actually not yet there.
This can be reproduced using Chrome 57 (on Windows) on latest master, TYPO3 in dev context and with network throttling set to 2G, caching disabled.
You will receive JS errors in the console where Editor.js is reported to access FormEngine.Validation.validate()
, where FormEngine.Validation
is undefined.
This is actually totally clear, when inspecting the dependencies close enough.
Updated by Gerrit Code Review over 7 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52168
Updated by Markus Klein over 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset b07bb2e9fb011a999a01ffb5ab323691f866179d.
Updated by Markus Klein over 7 years ago
- Status changed from Resolved to In Progress
Initial patch is replaced by better solution, therefore we reverted it.
Updated by Gerrit Code Review over 7 years ago
- Status changed from In Progress to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52178
Updated by Markus Klein over 7 years ago
- Status changed from Under Review to Resolved
Applied in changeset bfb2290ae3ceaffc783329c0bd54355e3fb38ee3.
Updated by Gerrit Code Review over 7 years ago
- Status changed from Resolved to Under Review
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52207
Updated by Gerrit Code Review over 7 years ago
Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52207
Updated by Markus Klein over 7 years ago
- Status changed from Under Review to Resolved
Applied in changeset 75501977b71fbe69572118c633ac95c052d34569.