Bug #80589
closedfilelist lacks items
100%
Description
Consider a folder with 42 files.
One of the file is a hidden file like .htaccess
the others are numbered from file10 to file50
Since each page in the filelist only shows up to 40 element and hidden files are not shown I would expect to see file50 as single item on the second page.
What actually happens is that the second page shows file49 again and file50 is never shown!
The reason is that LocalDrivers folder traversal logic uses the offset parameter (40 in case of the filelist) to forward the iterator to this starting point. This is wrong, since the iterator storage may contain elements before the offset, that might be filtered away by file filters (like hidden files).
The correct solution is to iterate over the whole storage and decrease the offset whenever a potentially valid file is found.
This way the expected behaviour can be seen.
Updated by Gerrit Code Review over 7 years ago
- Status changed from Accepted to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52275
Updated by Gerrit Code Review over 7 years ago
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52287
Updated by Gerrit Code Review over 7 years ago
Patch set 1 for branch TYPO3_6-2 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52288
Updated by Markus Klein over 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset e9ba80c2fb92fd0fbda65d473d0e0347fd9154f8.