Task #81366

Make sure all http_build_query() calls use a defined separator

Added by Markus Klein over 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Must have
Assignee:
Category:
Backend API
Target version:
Start date:
2017-05-29
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
easy
Sprint Focus:

Related issues

Related to TYPO3 Core - Bug #81293: cacheHash fails to be generated because of missing id although id is present in request-string Closed 2017-05-22

Associated revisions

Revision 78c524a7 (diff)
Added by Markus Klein over 2 years ago

[BUGFIX] Ensure correct URL generation with http_build_query()

http_build_query() internally uses the PHP setting arg-separator.output
to identify the URL parameter separator.
This does not seem appropriate for URLs generated by TYPO3.

Use the optional parameters of http_build_query() to get the desired
functionality.

Releases: master, 8.7, 7.6
Resolves: #81366
Change-Id: Ie2df9207b1967257d6327ff1103503e6a58d5cdf
Reviewed-on: https://review.typo3.org/52934
Tested-by: TYPO3com <>
Reviewed-by: Andreas Fernandez <>
Reviewed-by: Tymoteusz Motylewski <>
Tested-by: Tymoteusz Motylewski <>
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

Revision 2a086645 (diff)
Added by Markus Klein over 2 years ago

[BUGFIX] Ensure correct URL generation with http_build_query()

http_build_query() internally uses the PHP setting arg-separator.output
to identify the URL parameter separator.
This does not seem appropriate for URLs generated by TYPO3.

Use the optional parameters of http_build_query() to get the desired
functionality.

Releases: master, 8.7, 7.6
Resolves: #81366
Change-Id: Ie2df9207b1967257d6327ff1103503e6a58d5cdf
Reviewed-on: https://review.typo3.org/52964
Reviewed-by: Georg Ringer <>
Tested-by: Georg Ringer <>

Revision 473a1836 (diff)
Added by Markus Klein over 2 years ago

[BUGFIX] Ensure correct URL generation with http_build_query()

http_build_query() internally uses the PHP setting arg-separator.output
to identify the URL parameter separator.
This does not seem appropriate for URLs generated by TYPO3.

Use the optional parameters of http_build_query() to get the desired
functionality.

Releases: master, 8.7, 7.6
Resolves: #81366
Change-Id: Ie2df9207b1967257d6327ff1103503e6a58d5cdf
Reviewed-on: https://review.typo3.org/52966
Tested-by: TYPO3com <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

History

#1 Updated by Gerrit Code Review over 2 years ago

  • Status changed from Accepted to Under Review

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52934

#2 Updated by Markus Klein over 2 years ago

  • Related to Bug #81293: cacheHash fails to be generated because of missing id although id is present in request-string added

#3 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52934

#4 Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52964

#5 Updated by Markus Klein over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Gerrit Code Review over 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/52966

#7 Updated by Markus Klein over 2 years ago

  • Status changed from Under Review to Resolved

#8 Updated by Benni Mack over 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF