Bug #81624

ContentObjectRenderer not fully initialized in f:format.html ViewHelper

Added by Torsten Schrade almost 2 years ago. Updated 8 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2017-06-20
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

\TYPO3\CMS\Fluid\ViewHelpers\Format\HtmlViewHelper->renderStatic() misses a call to \TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer->start() after instantiation and before it passes the content to parseFunc.

Because of this the $hookObjects of ContentObjectRenderer are not initialized during the processing with parseFunc in f.format.html. This makes it impossible to apply own TypoScript cObjects via $this->cObjHookObjectsRegistry (like the XSLT or XPATH content objects for example) or own extensions to stdWrap functions via $this->stdWrapHookObjects.

The solution is to call $contentObject->start([], '') after instantiation (just like it's done in TYPO3\CMS\Fluid\ViewHelpers\Link\TypolinkViewHelper).

This issue applies to all versions from 7.6 onwards.


Related issues

Related to TYPO3 Core - Bug #75314: HtmlViewHelper ignores stdwrap hooks Closed 2016-03-30

Associated revisions

Revision 3ba04e4b (diff)
Added by Torsten Schrade almost 2 years ago

[BUGFIX] Fully initialize ContentObjectRenderer in HtmlViewHelper

Add a call to the start function of ContentObjectRenderer after
instantiation. This is necessary to get all hooks fully initialized.

Resolves: #81624
Resolves: #75314
Releases: master, 8.7, 7.6
Change-Id: I75d30e860cd77a1b233d4383a3e57afe9a34ec54
Reviewed-on: https://review.typo3.org/53264
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Wouter Wolters <>
Tested-by: TYPO3com <>
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>

Revision b3316347 (diff)
Added by Torsten Schrade almost 2 years ago

[BUGFIX] Fully initialize ContentObjectRenderer in HtmlViewHelper

Add a call to the start function of ContentObjectRenderer after
instantiation. This is necessary to get all hooks fully initialized.

Resolves: #81624
Resolves: #75314
Releases: master, 8.7, 7.6
Change-Id: I75d30e860cd77a1b233d4383a3e57afe9a34ec54
Reviewed-on: https://review.typo3.org/53336
Tested-by: TYPO3com <>
Reviewed-by: Wouter Wolters <>
Reviewed-by: Torsten Schrade <>
Tested-by: Torsten Schrade <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>

Revision a928f30c (diff)
Added by Torsten Schrade almost 2 years ago

[BUGFIX] Fully initialize ContentObjectRenderer in HtmlViewHelper

Add a call to the start function of ContentObjectRenderer after
instantiation. This is necessary to get all hooks fully initialized.

Resolves: #81624
Resolves: #75314
Releases: master, 8.7, 7.6
Change-Id: I75d30e860cd77a1b233d4383a3e57afe9a34ec54
Reviewed-on: https://review.typo3.org/53338
Tested-by: TYPO3com <>
Reviewed-by: Markus Klein <>
Tested-by: Markus Klein <>
Reviewed-by: Torsten Schrade <>
Tested-by: Torsten Schrade <>

History

#1 Updated by Torsten Schrade almost 2 years ago

  • Description updated (diff)

#2 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53264

#3 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53264

#4 Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53264

#5 Updated by Markus Klein almost 2 years ago

  • Related to Bug #75314: HtmlViewHelper ignores stdwrap hooks added

#6 Updated by Gerrit Code Review almost 2 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53336

#7 Updated by Torsten Schrade almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#8 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Resolved to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53338

#9 Updated by Torsten Schrade almost 2 years ago

  • Status changed from Under Review to Resolved

#10 Updated by Benni Mack 8 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF