Bug #81709

Multiple INCLUDE_TYPOSCRIPT extensions with spaces not working

Added by Mathias Brodala over 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
TypoScript
Target version:
Start date:
2017-06-27
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

The following TypoScript snippet won't include files with anything but the first file extension:

<INCLUDE_TYPOSCRIPT: source="DIR: ./Library" extensions="ts, setupts, tx">

The reason is the space after the comma which in the end lets TypoScriptParser::includeDirectory() (more specifically GeneralUtility::getFilesInDir() handle them as "ts", " setupts" and " tx" (mind the leading space).

This should probably cleaned up with GeneralUtility::trimExplode().

Associated revisions

Revision fc12d545 (diff)
Added by Daniel Goerz over 2 years ago

[BUGFIX] Allow whitespaces in list of file extensions

This ensures that spaces can be used to format the list of file
extensions for <INCLUDE_TYPOSCRIPT>.

Resolves: #81709
Releases: master, 8.7
Change-Id: Ia0c830df52b18a3dae7bd724c4bd5ee3b845e00f
Reviewed-on: https://review.typo3.org/53337
Reviewed-by: Mathias Brodala <>
Tested-by: Mathias Brodala <>
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision 307b3752 (diff)
Added by Daniel Goerz over 2 years ago

[BUGFIX] Allow whitespaces in list of file extensions

This ensures that spaces can be used to format the list of file
extensions for <INCLUDE_TYPOSCRIPT>.

Resolves: #81709
Releases: master, 8.7
Change-Id: Ia0c830df52b18a3dae7bd724c4bd5ee3b845e00f
Reviewed-on: https://review.typo3.org/53354
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Gerrit Code Review over 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53337

#2 Updated by Gerrit Code Review over 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53337

#3 Updated by Gerrit Code Review over 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53337

#4 Updated by Gerrit Code Review over 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53337

#5 Updated by Gerrit Code Review over 2 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53354

#6 Updated by Anonymous over 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF