Project

General

Profile

Actions

Bug #81714

closed

No valid HTML output Form->DatePicker

Added by Björn Paulsen over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Form Framework
Target version:
Start date:
2017-06-27
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
Tags:
form,datepicker
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

Hello Together,

the SysExt Form in Typo 3 8.7.2 renders wrong html for DatePicker.

This is wrong:

<input class="small form-control" id="kontakt-datepicker-1" type="input" name="tx_form_formframework[kontakt][datepicker-1][date]" placeholder="d.m.Y" readonly="1" />

This is right

<input class="small form-control" id="kontakt-datepicker-1" type="text" name="tx_form_formframework[kontakt][datepicker-1][date]" placeholder="d.m.Y" readonly="readonly" />

It is wrong in Class typo3/sysext/form/Classes/ViewHelpers/Form/DatePickerViewHelper.php:
Line 90:

Wrong:

$this->tag->addAttribute('type', 'input');

Right:

$this->tag->addAttribute('type', 'text');

Line 104:

Wrong:

$this->tag->addAttribute('readonly', true);

Right:

$this->tag->addAttribute('readonly', 'readonly');

Thank you for change.

Actions #1

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53361

Actions #2

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53361

Actions #3

Updated by Gerrit Code Review over 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53420

Actions #4

Updated by Ralf Zimmermann over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #5

Updated by Daniel Ruf over 6 years ago

Not sure why readonly is used here at all.

Actions #6

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF