Bug #81949

cglFixMyCommit.sh won't work on Windows

Added by Jigal van Hemert over 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2017-07-24
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.0
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Build/Scripts/cglFixMyCommit.sh contains the weird construction where a shell script is passed to the PHP executable. This is probably done to make sure that the custom configuration of PHP is used in PHP scripts later on in the chain.
Apparently PHP is capable of running shell scripts. Even though I executed the script in Git Bash (part of Git for Windows; supports shebangs and many other bash features) it seems that PHP internally opens a Windows shell to execute the script. This won't work with shell scripts made for Linux.

In TYPO3 v7 the script was running fine, but after the changes to "squeeze the last bit of performance" out of the script it fails. Perhaps a version (.bat file?) can be made that contains the old methods? These ran pretty fast

#1

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53669

#2

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53669

#3

Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53678

#4

Updated by Anonymous over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#5

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF