Bug #82044: YouTubeRenderer ignores "controls" option - TYPO3 Core - TYPO3 Forge

Actions

Copy link

Bug #82044

closed

YouTubeRenderer ignores "controls" option

Added by Česlav Przywara over 7 years ago. Updated about 6 years ago.

Status:

Closed

Priority:

Should have

Assignee:

Category:

Content Rendering

Target version:

Start date:

2017-08-04

Due date:

% Done:

100%

Estimated time:

TYPO3 Version:

PHP Version:

Tags:

Complexity:

Is Regression:

Sprint Focus:

Description

Hi,

I noticed that TYPO3\CMS\Core\Resource\Rendering\YouTubeRenderer almost completely ignores value of "controls" option:

if (!isset($options['controls']) || !empty($options['controls'])) {
    $urlParams[] = 'controls=2';
}

With $options['controls'] = '0' or similar empty value, the controls attribute is not added to embed URL, but then YouTube defaults to controls=1, what is most likely not what you want. See: https://developers.google.com/youtube/player_parameters?hl=en#controls

I have noticed this in TYPO3 7, but patch is based on trunk.

Files

YouTubeRenderer.patch (853 Bytes) YouTubeRenderer.patch

Česlav Przywara, 2017-08-04 13:29

Actions

Copy link

Updated by Frans Saris over 7 years ago

Hi, tnx for the patch.

Could you maybe push it to our review system? https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650

Actions

Copy link

Updated by Gerrit Code Review over 7 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650

Actions

Copy link

#10

Updated by Gerrit Code Review over 7 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53708

Actions

Copy link

#11

Updated by Gerrit Code Review over 7 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53709

Actions

Copy link

#12