Bug #82044

YouTubeRenderer ignores "controls" option

Added by Česlav Przywara over 3 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Content Rendering
Target version:
-
Start date:
2017-08-04
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

Hi,

I noticed that TYPO3\CMS\Core\Resource\Rendering\YouTubeRenderer almost completely ignores value of "controls" option:

if (!isset($options['controls']) || !empty($options['controls'])) {
    $urlParams[] = 'controls=2';
}

With $options['controls'] = '0' or similar empty value, the controls attribute is not added to embed URL, but then YouTube defaults to controls=1, what is most likely not what you want. See: https://developers.google.com/youtube/player_parameters?hl=en#controls

I have noticed this in TYPO3 7, but patch is based on trunk.


Files

YouTubeRenderer.patch (853 Bytes) YouTubeRenderer.patch Česlav Przywara, 2017-08-04 13:29
#1

Updated by Frans Saris over 3 years ago

Hi, tnx for the patch.

Could you maybe push it to our review system? https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/

#2

Updated by Gerrit Code Review over 3 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650

#3

Updated by Gerrit Code Review over 3 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650

#4

Updated by Gerrit Code Review over 3 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650

#5

Updated by Gerrit Code Review over 3 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650

#6

Updated by Gerrit Code Review over 3 years ago

Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650

#7

Updated by Gerrit Code Review over 3 years ago

Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650

#8

Updated by Gerrit Code Review over 3 years ago

Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650

#9

Updated by Gerrit Code Review over 3 years ago

Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650

#10

Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53708

#11

Updated by Gerrit Code Review over 3 years ago

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53709

#12

Updated by Česlav Przywara over 3 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
#13

Updated by Benni Mack over 2 years ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF