Bug #82044
closedYouTubeRenderer ignores "controls" option
100%
Description
Hi,
I noticed that TYPO3\CMS\Core\Resource\Rendering\YouTubeRenderer
almost completely ignores value of "controls" option:
if (!isset($options['controls']) || !empty($options['controls'])) { $urlParams[] = 'controls=2'; }
With $options['controls'] = '0'
or similar empty value, the controls attribute is not added to embed URL, but then YouTube defaults to controls=1
, what is most likely not what you want. See: https://developers.google.com/youtube/player_parameters?hl=en#controls
I have noticed this in TYPO3 7, but patch is based on trunk.
Files
Updated by Frans Saris over 7 years ago
Hi, tnx for the patch.
Could you maybe push it to our review system? https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/
Updated by Gerrit Code Review over 7 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650
Updated by Gerrit Code Review over 7 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650
Updated by Gerrit Code Review over 7 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650
Updated by Gerrit Code Review over 7 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650
Updated by Gerrit Code Review over 7 years ago
Patch set 5 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650
Updated by Gerrit Code Review over 7 years ago
Patch set 6 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650
Updated by Gerrit Code Review over 7 years ago
Patch set 7 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650
Updated by Gerrit Code Review over 7 years ago
Patch set 8 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53650
Updated by Gerrit Code Review over 7 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53708
Updated by Gerrit Code Review over 7 years ago
Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53709
Updated by Česlav Przywara over 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset f6c2b2e55f80a8193b15f294ae974d2832ba900d.