Bug #82052

Form exception breaks page module

Added by Mathias Brodala about 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Must have
Category:
Form Framework
Target version:
Start date:
2017-08-07
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Description

If a form is selected and renamed afterwards, the page module breaks due to a TYPO3\CMS\Form\Mvc\Configuration\Exception\NoSuchFileException being thrown.

The FormPagePreviewRenderer catches instances of TYPO3\CMS\Core\Error\Exception but TYPO3\CMS\Form\Exception only extends \Exception.

Associated revisions

Revision 929c02c7 (diff)
Added by Mathias Brodala about 2 years ago

[BUGFIX] Let all toplevel exceptions extend the core exception

This is a small step to unify exception handling in TYPO3 by
ensuring no internal and 3rd party code is forced to catch the
toplevel PHP exception.

This change e.g. actually allows the FormPagePreviewRenderer to
handle form loading errors.

Resolves: #82052
Releases: master, 8.7
Change-Id: I5cb0b8f2c56a6bbbecc34d87474d6d8b3ad2015c
Reviewed-on: https://review.typo3.org/53651
Reviewed-by: Wolfgang Klinger <>
Tested-by: TYPO3com <>
Reviewed-by: Mathias Schreiber <>
Tested-by: Mathias Schreiber <>
Reviewed-by: Joerg Boesche <>
Tested-by: Joerg Boesche <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

Revision 7e51baf6 (diff)
Added by Mathias Brodala about 2 years ago

[BUGFIX] Let all toplevel exceptions extend the core exception

This is a small step to unify exception handling in TYPO3 by
ensuring no internal and 3rd party code is forced to catch the
toplevel PHP exception.

This change e.g. actually allows the FormPagePreviewRenderer to
handle form loading errors.

Resolves: #82052
Releases: master, 8.7
Change-Id: I5cb0b8f2c56a6bbbecc34d87474d6d8b3ad2015c
Reviewed-on: https://review.typo3.org/53675
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

History

#1 Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53651

#2 Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53651

#3 Updated by Gerrit Code Review about 2 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53675

#4 Updated by Mathias Brodala about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 50 to 100

#5 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF