TYPO3 Core

The logic is , we need to run the extractMetaData() function only if the file is of allowable type and that is what the condition check will do.

--- Indexer_orig.php    2017-08-09 16:02:52.912607837 +0530
+++ Indexer.php    2017-08-09 16:10:08.404625955 +0530
@@ -106,8 +106,12 @@
     {
         $fileIndexRecords = $this->getFileIndexRepository()->findInStorageWithIndexOutstanding($this->storage, $maximumFileCount);
         foreach ($fileIndexRecords as $indexRecord) {
+           $isAllowed = GeneralUtility::verifyFilenameAgainstDenyPattern($indexRecord['name']);
+           if ($isAllowed) {
             $fileObject = $this->getResourceFactory()->getFileObject($indexRecord['uid'], $indexRecord);
             $this->extractMetaData($fileObject);
+           }
         }
     }

As my membership in core project is still pending, can anyone please take this task and apply this patch?

Hi Ricky,

tnx for the patch. You don't have to be a member of the core to push patches to Gerrit. Like most other OS projects everyone is allowed to push patches.

https://docs.typo3.org/typo3cms/ContributionWorkflowGuide/

Please let us know if you need further assistance with pushing this to Gerrit. On our Slack channel there is always someone around that's willing to assist you. https://forger.typo3.org/slack

btw maybe is't easier to just catch the InsufficientFileAccessPermissionsException. So add a

try { 
 ...
} catch(InsufficientFileAccessPermissionsException $e) {}

arround the call

Frans Saris wrote:

btw maybe is't easier to just catch the InsufficientFileAccessPermissionsException. So add a

[...]

arround the call

But that will throw the exception and stops the scheduler execution..But we just need to skip the denied files. that's all

No it does mainly the same as your solution

         $fileIndexRecords = $this->getFileIndexRepository()->findInStorageWithIndexOutstanding($this->storage, $maximumFileCount);
         foreach ($fileIndexRecords as $indexRecord) {
           try {
             $fileObject = $this->getResourceFactory()->getFileObject($indexRecord['uid'], $indexRecord);
             $this->extractMetaData($fileObject);
           } catch(InsufficientFileAccessPermissionsException $e) {}
         }

It will still loop thought all items

Frans Saris wrote:

No it does mainly the same as your solution

[...]

It will still loop thought all items

Okay.Let me check whether it works for me.

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53834

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/53834

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54708