Task #82506

Remove BackendUserRepository injection in NoteController

Added by Georg Ringer almost 2 years ago. Updated 10 months ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
Code Cleanup
Target version:
-
Start date:
2017-09-19
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
Tags:
Complexity:
Sprint Focus:

Description

The NoteController does not really need the current user as object. Skip the call and just use the id.

Associated revisions

Revision f4b66731 (diff)
Added by Georg Ringer almost 2 years ago

[TASK] Remove BackendUserRepository injection in NoteController

To improve the performance of sys_note rendering, the injection can
be skipped as the current user id can be used directly.

Resolves: #82506
Releases: master
Change-Id: I40b04ac725628f4dcfb3f1e5a280edf9c8e545f9
Reviewed-on: https://review.typo3.org/54166
Reviewed-by: Benni Mack <>
Tested-by: Benni Mack <>
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>

History

#1 Updated by Georg Ringer almost 2 years ago

  • Subject changed from Remove BackendUserRepository injeciton in NoteController to Remove BackendUserRepository injection in NoteController

#2 Updated by Gerrit Code Review almost 2 years ago

  • Status changed from Accepted to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54166

#3 Updated by Gerrit Code Review almost 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54166

#4 Updated by Gerrit Code Review almost 2 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54166

#5 Updated by Gerrit Code Review almost 2 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54166

#6 Updated by Georg Ringer almost 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Benni Mack 10 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF