Project

General

Profile

Actions

Bug #82547

closed

Icon overlay accepts empty string as identifier

Added by Romain Canon over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
-
Target version:
Start date:
2017-09-23
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
9
PHP Version:
Tags:
icon, overlay
Complexity:
Is Regression:
Sprint Focus:

Description

When getting an icon with the overlay parameter containing an empty string, the API considers the parameter is filled and returns the "not found icon".

The best example is this Fluid snippet:

<core:icon identifier="tx-my-icon" 
           overlay="{f:if(condition: myCondition, then: 'my-overlay-icon')}" />

When the condition myCondition is false, the "not found icon" is added as an overlay, but no overlay should be added at all.

Actions #1

Updated by Romain Canon over 6 years ago

  • Description updated (diff)
Actions #2

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54212

Actions #3

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54212

Actions #4

Updated by Gerrit Code Review over 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54212

Actions #5

Updated by Romain Canon over 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #6

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF