Bug #82565
closedImprove performance for version nr of file
100%
Description
When processing javascript and css, typo3 currently incorrectly tries to process resources loaded from external as local resources, cause some very expensive file_exists calls.
In the function createVersionNumberedFilename($file) which will make the filename automatically change when a file is changed and re-cached by the browser will check for existence of the file and that might be expensive when we do not have the file and mode is not either 'embed' or 'querystring'
Setting $GLOBALS['TYPO3_CONF_VARS']['FE']['versionNumberInFilename'] = ''
Will still cause a check to the local filesystime, because
GeneralUtility::createVersionNumberedFilename
..
if (!file_exists($path) || $doNothing) {
One solution is to change this to
if ($doNothing || !file_exists($path)) {
Updated by Gerrit Code Review about 7 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54221
Updated by Gerrit Code Review about 7 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54221
Updated by Gerrit Code Review about 7 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54238
Updated by Faton Haliti about 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset aa7dcb6573789a5012ed0026b0f69f37e86a6280.