Task #82669

Resolve backend route path inconsistencies

Added by Oliver Hader about 2 years ago. Updated 3 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
Backend API
Target version:
-
Start date:
2017-10-04
Due date:
% Done:

100%

TYPO3 Version:
9
PHP Version:
7.0
Tags:
Complexity:
Sprint Focus:

Description

There are inconsistencies in working with route path names depending on how these routes have been provided:

  • path /file/editcontent (no trailing slash) is the result of a direct route configuration in typo3_src/typo3/sysext/backend/Configuration/Backend/Routes.php
  • path /web/WorkspacesWorkspaces/ (with trailing slash) is the result of a backend module configuration which builds the path name internally
    • see \TYPO3\CMS\Extbase\Utility\ExtensionUtility::registerModule
    • see \TYPO3\CMS\Core\Utility\ExtensionManagementUtility::addModule
    • find $path = '/' . trim($path, '/') . '/'; - thus always containing a slash in the end

To have a proper schema of using routes, either the slash should be stripped from the end or added in all cases.

Associated revisions

Revision 351e83fd (diff)
Added by Benni Mack 4 months ago

[TASK] Unify Backend Route paths for modules

Modules which do not set a proper route path themselves
now have a different route path, basically "/module/file/list"
for example, whereas there is a proper prefix with
"/module/" and no trailing slash anymore.

It is still possible to build links to the route paths,
and resolve them properly.

The "old" route paths will stop working in TYPO3 v11.0.

Resolves: #82669
Releases: master
Change-Id: If976df458e87b1199933cf1c42c5d3d8ff2407ba
Reviewed-on: https://review.typo3.org/c/Packages/TYPO3.CMS/+/60433
Tested-by: TYPO3com <>
Tested-by: Susanne Moog <>
Tested-by: Daniel Gorges <>
Tested-by: Benni Mack <>
Reviewed-by: Susanne Moog <>
Reviewed-by: Daniel Gorges <>
Reviewed-by: Benni Mack <>

History

#1 Updated by Oliver Hader about 2 years ago

  • Description updated (diff)

#2 Updated by Gerrit Code Review 6 months ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60433

#3 Updated by Gerrit Code Review 6 months ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60433

#4 Updated by Gerrit Code Review 6 months ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60433

#5 Updated by Gerrit Code Review 5 months ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/c/Packages/TYPO3.CMS/+/60433

#6 Updated by Benni Mack 4 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#7 Updated by Benni Mack 3 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF