Bug #82793

Localization State does not properly sanitize and enrich

Added by Oliver Hader about 2 years ago. Updated about 1 year ago.

Status:
Closed
Priority:
Should have
Assignee:
Category:
DataHandler aka TCEmain
Target version:
-
Start date:
2017-10-17
Due date:
% Done:

100%

TYPO3 Version:
8
PHP Version:
Tags:
Complexity:
easy
Is Regression:
Sprint Focus:

Description

The Localization State object has an incomplete assignment is the constructor - sanitize processing is overriden by enrich processing, however both should be combined instead.

Credits

Thanks to Georg Ringer for finding this issue and letting me know.

Associated revisions

Revision 85836c4c (diff)
Added by Oliver Hader about 2 years ago

[BUGFIX] Localization State does not properly sanitize and enrich

The Localization State object has an incomplete assignment in the
constructor - sanitize processing is overridden by enrich processing,
however both should be combined instead.

The current side-effects were, that
  • localization state could contain fields that were not defined in TCA
    having support for the `allowLanguageSynchronization` setting
  • state values different than `custom`, `source` or `parent` have not
    been overridden by the default `parent` value

Resolves: #82793
Releases: 8.7, master
Change-Id: I25e794736df216b17a5b8de3bc5203bd18ee9694
Reviewed-on: https://review.typo3.org/54422
Tested-by: TYPO3com <>
Reviewed-by: Susanne Moog <>
Tested-by: Susanne Moog <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

Revision 7316340f (diff)
Added by Oliver Hader about 2 years ago

[BUGFIX] Localization State does not properly sanitize and enrich

The Localization State object has an incomplete assignment in the
constructor - sanitize processing is overridden by enrich processing,
however both should be combined instead.

The current side-effects were, that
  • localization state could contain fields that were not defined in TCA
    having support for the `allowLanguageSynchronization` setting
  • state values different than `custom`, `source` or `parent` have not
    been overridden by the default `parent` value

Resolves: #82793
Releases: 8.7, master
Change-Id: I25e794736df216b17a5b8de3bc5203bd18ee9694
Reviewed-on: https://review.typo3.org/54427
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Gerrit Code Review about 2 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54422

#2 Updated by Oliver Hader about 2 years ago

  • Description updated (diff)

#3 Updated by Gerrit Code Review about 2 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54422

#4 Updated by Gerrit Code Review about 2 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54427

#5 Updated by Oliver Hader about 2 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#6 Updated by Benni Mack about 1 year ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF