Bug #83058
closedMissing initialization of GraphicalFunctions in LocalImageProcessor
100%
Description
On line 164 of typo3/sysext/core/Classes/Resource/Processing/LocalImageProcessor.php
an instance of \TYPO3\CMS\Core\Imaging\GraphicalFunctions
is created:
$graphicalFunctionsObject = GeneralUtility::makeInstance(GraphicalFunctions::class);
What's missing, however, is the mandatory call to ->init()
afterwards (see method comment "Must always call this when using the class."). As a result, several configuration settings will be ignored (e.g. $GLOBALS['TYPO3_CONF_VARS']['GFX']['imagefile_ext']
) during image processing.
Solution: call the ->init()
method right after instantiation.
$graphicalFunctionsObject = GeneralUtility::makeInstance(GraphicalFunctions::class); $graphicalFunctionsObject->init();
Updated by Frans Saris almost 7 years ago
Hi, tnx for finding this.
Could you push a patch for this to our review system?
Updated by Gerrit Code Review almost 7 years ago
- Status changed from New to Under Review
Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54717
Updated by Gerrit Code Review almost 7 years ago
Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54717
Updated by Gerrit Code Review almost 7 years ago
Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54717
Updated by Gerrit Code Review almost 7 years ago
Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54717
Updated by Gerrit Code Review almost 7 years ago
Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54771
Updated by Joschi Kuphal almost 7 years ago
- Status changed from Under Review to Resolved
- % Done changed from 0 to 100
Applied in changeset 63a2a917dae2bb03097aae19029446d9dddaec0b.