Project

General

Profile

Actions

Bug #83058

closed

Missing initialization of GraphicalFunctions in LocalImageProcessor

Added by Joschi Kuphal over 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Must have
Assignee:
-
Category:
Image Cropping
Target version:
Start date:
2017-11-21
Due date:
% Done:

100%

Estimated time:
TYPO3 Version:
8
PHP Version:
7.1
Tags:
Complexity:
no-brainer
Is Regression:
Sprint Focus:

Description

On line 164 of typo3/sysext/core/Classes/Resource/Processing/LocalImageProcessor.php an instance of \TYPO3\CMS\Core\Imaging\GraphicalFunctions is created:

$graphicalFunctionsObject = GeneralUtility::makeInstance(GraphicalFunctions::class);

What's missing, however, is the mandatory call to ->init() afterwards (see method comment "Must always call this when using the class."). As a result, several configuration settings will be ignored (e.g. $GLOBALS['TYPO3_CONF_VARS']['GFX']['imagefile_ext']) during image processing.

Solution: call the ->init() method right after instantiation.

$graphicalFunctionsObject = GeneralUtility::makeInstance(GraphicalFunctions::class);
$graphicalFunctionsObject->init();
Actions #1

Updated by Frans Saris over 6 years ago

Hi, tnx for finding this.

Could you push a patch for this to our review system?

Actions #2

Updated by Gerrit Code Review over 6 years ago

  • Status changed from New to Under Review

Patch set 1 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54717

Actions #3

Updated by Gerrit Code Review over 6 years ago

Patch set 2 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54717

Actions #4

Updated by Gerrit Code Review about 6 years ago

Patch set 3 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54717

Actions #5

Updated by Gerrit Code Review about 6 years ago

Patch set 4 for branch master of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54717

Actions #6

Updated by Gerrit Code Review about 6 years ago

Patch set 1 for branch TYPO3_8-7 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54771

Actions #7

Updated by Joschi Kuphal about 6 years ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100
Actions #8

Updated by Benni Mack over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF