Bug #83209

Epic #82226: PHP 7.2

Undefined constant OCI_COMMIT_ON_SUCCESS

Added by Christian Kuhn 3 months ago. Updated 3 months ago.

Status:
Resolved
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2017-12-03
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Associated revisions

Revision db0607da (diff)
Added by Christian Kuhn 3 months ago

[BUGFIX] Undefined constant OCI_COMMIT_ON_SUCCESS

Test suite on core v7 with PHP 7.2 complains a lot about
"Undefined constant OCI_COMMIT_ON_SUCCESS". This is
found in the adodb oracle oci8 driver, used as property
default value and thus evaluated as soon as the driver class
is instantiated in tests.
The test suite does not include oci8 in php. The php module
sets constant OCI_COMMIT_ON_SUCCESS to hex '0x20' which is
32 in decimal.
The patch uses decimal 32 to suppress the warning if
oci8 module is not loaded for tests.

Change-Id: I218e9758fe8b1bf8a92a8398f6782faa4ed4c9c9
Resolves: #83209
Releases: 7.6
Reviewed-on: https://review.typo3.org/54923
Tested-by: TYPO3com <>
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>

History

#1 Updated by Gerrit Code Review 3 months ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54923

#2 Updated by Christian Kuhn 3 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

Also available in: Atom PDF