Bug #83211

Epic #82226: PHP 7.2

Tests: define TYPO3_REQUESTTYPE

Added by Christian Kuhn 12 months ago. Updated about 2 months ago.

Status:
Closed
Priority:
Should have
Assignee:
-
Category:
-
Target version:
-
Start date:
2017-12-03
Due date:
% Done:

100%

TYPO3 Version:
7
PHP Version:
Tags:
Complexity:
Is Regression:
Sprint Focus:

Associated revisions

Revision 20182ea1 (diff)
Added by Christian Kuhn 12 months ago

[BUGFIX] Unit tests: Define TYPO3_REQUESTTYPE

Unit test boostrap does not initialize constants
TYPO3_REQUESTTYPE and TYPO3_REQUESTTYPE_*, but various
tests rely on this basic constants being properly defined
in core v7. With PHP 7.2, accessing undefined connstants
throws warnings.
Patch makes according bootstrap method public and calls
it during unit test bootstrap.

Change-Id: I450e440694385244c554adef00a9c74135d457f5
Resolves: #83211
Releases: 7.6
Reviewed-on: https://review.typo3.org/54925
Reviewed-by: Christian Kuhn <>
Tested-by: Christian Kuhn <>
Tested-by: TYPO3com <>

History

#1 Updated by Gerrit Code Review 12 months ago

  • Status changed from New to Under Review

Patch set 1 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54925

#2 Updated by Gerrit Code Review 12 months ago

Patch set 2 for branch TYPO3_7-6 of project Packages/TYPO3.CMS has been pushed to the review server.
It is available at https://review.typo3.org/54925

#3 Updated by Christian Kuhn 12 months ago

  • Status changed from Under Review to Resolved
  • % Done changed from 0 to 100

#4 Updated by Benni Mack about 2 months ago

  • Status changed from Resolved to Closed

Also available in: Atom PDF